id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
1705	If you make an instance of a class without supplying kwargs the result is an instance with defects.	emil.gruno@…	Adrian Holovaty	"'''Intro'''

I am puzzled by the way one create an instance of a class, you have to
parse valid (memberdata) fieldname='foobar' to create the instance with the
memberdata attributes from self._meta.fields

'''Example;'''

The first example shows what i mean;


{{{
mysite/myapp/models.py

# -*- coding: cp1252 -*-
from django.db import models
class TestModel(models.Model):
    memberdata = models.CharField(maxlength=100)

>>> from mysite.myapp.models import TestModel
>>> t = TestModel()
>>> dir(t)

['AddManipulator', 'ChangeManipulator', 'DoesNotExist', '__class__',
'__delattr_
_', '__dict__', '__doc__', '__eq__', '__getattribute__', '__hash__',
'__init__',
 '__metaclass__', '__module__', '__ne__', '__new__', '__reduce__',
'__reduce_ex_
_', '__repr__', '__setattr__', '__str__', '__weakref__',
'_collect_sub_objects',
 '_default_manager', '_get_FIELD_display', '_get_FIELD_filename',
'_get_FIELD_he
ight', '_get_FIELD_size', '_get_FIELD_url', '_get_FIELD_width',
'_get_image_dime
nsions', '_get_next_or_previous_by_FIELD',
'_get_next_or_previous_in_order', '_g
et_pk_val', '_meta', '_prepare', '_save_FIELD_file',
'_set_related_many_to_many'
, 'add_to_class', 'delete', 'objects', 'save', 'validate']

id, memberdata etc.. is missing

>>> t = TestModel(memberdata='Hello World')
>>> dir(t)

['AddManipulator', 'ChangeManipulator', 'DoesNotExist', '__class__',
'__delattr_
_', '__dict__', '__doc__', '__eq__', '__getattribute__', '__hash__',
'__init__',
 '__metaclass__', '__module__', '__ne__', '__new__', '__reduce__',
'__reduce_ex_
_', '__repr__', '__setattr__', '__str__', '__weakref__',
'_collect_sub_objects',
 '_default_manager', '_get_FIELD_display', '_get_FIELD_filename',
'_get_FIELD_he
ight', '_get_FIELD_size', '_get_FIELD_url', '_get_FIELD_width',
'_get_image_dime
nsions', '_get_next_or_previous_by_FIELD',
'_get_next_or_previous_in_order', '_g
et_pk_val', '_meta', '_prepare', '_save_FIELD_file',
'_set_related_many_to_many'
, 'add_to_class', 'delete', 'id', 'memberdata', 'objects', 'save',
'validate']

}}}

if i had a member function like this:


{{{
def __repr__(self):
        return self.memberdata
}}}

And call it like this:

{{{
t = TestModel()
t + enter
}}}

This will fail to represent it self. =/ i think it should
not.

the following patch will fix that:


{{{
Index: magic-removal/django/db/models/base.py
===================================================================
--- magic-removal/django/db/models/base.py      (revision 2747)
+++ magic-removal/django/db/models/base.py      (working copy)
 -107,6 +107,9 @@
                     setattr(self, f.attname, val)
             if kwargs:
                 raise TypeError, ""'%s' is an invalid keyword argument
for this function"" % kwargs.keys()[0]
+        else:
+            for f in self._meta.fields:
+                setattr(self, f.attname, None)
         for i, arg in enumerate(args):
             setattr(self, self._meta.fields[i].attname, arg)
         dispatcher.send(signal=signals.post_init,
sender=self.__class__, instance=self)
}}}


Cheers, 

Emil Gruno"	defect	closed	Core (Other)		normal	fixed			Unreviewed	0	0	0	0	0	0