Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#16789 closed Cleanup/optimization (fixed)

use named urls in django.contrib.auth.urls

Reported by: wim@… Owned by: fcurella
Component: contrib.auth Version: 1.3
Severity: Normal Keywords:
Cc: chris@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

Use named urls in django.contrib.auth: eat own dogfood and make it possible to use reverse auth urls for everyone! Freedom to the people!

Attachments (3)

named_auth_urls_ticket16789.diff (2.0 KB) - added by wim@… 4 years ago.
add names to auth/urls.py
t16789-with-docs.diff (5.1 KB) - added by cmheisel 4 years ago.
Named URL patterns plus docs
t16789-with-docs-and-tests.diff (7.3 KB) - added by cmheisel 4 years ago.
Docs and tests

Download all attachments as: .zip

Change History (19)

Changed 4 years ago by wim@…

add names to auth/urls.py

comment:1 Changed 4 years ago by fcurella

  • Component changed from Uncategorized to contrib.auth
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 4 years ago by fcurella

  • Has patch set
  • Needs documentation set

I think we should document the view names somewhere in the docs.

comment:3 Changed 4 years ago by cmheisel

  • Owner changed from nobody to cmheisel
  • Status changed from new to assigned

comment:4 Changed 4 years ago by cmheisel

  • Needs documentation unset
  • Owner changed from cmheisel to fcurella
  • Status changed from assigned to new
  • Triage Stage changed from Unreviewed to Accepted

Updated patch with documentation. Sending to fcurella for review.

comment:5 Changed 4 years ago by wim@…

Hi cmheisel,

It seems the diff contains more than one fix. Could you please look into this?

Thanks!

Wim

Changed 4 years ago by cmheisel

Named URL patterns plus docs

comment:6 Changed 4 years ago by cmheisel

Wim / fcurella -- sorry about that! Fixed the patch.

comment:7 Changed 4 years ago by cmheisel

  • Cc chris@… added

comment:8 Changed 4 years ago by fcurella

  • Triage Stage changed from Accepted to Ready for checkin

comment:9 Changed 4 years ago by fcurella

  • Needs tests set
  • Triage Stage changed from Ready for checkin to Accepted

Not sure if tests for this path would be overkill.

Version 0, edited 4 years ago by fcurella (next)

comment:10 Changed 4 years ago by wim@…

We could just do a reverse lookup for the url names?

Changed 4 years ago by cmheisel

Docs and tests

comment:11 Changed 4 years ago by cmheisel

  • Needs tests unset

Added a new patch that includes tests as well

comment:12 Changed 4 years ago by wim@…

Hi cmheisel,

Thanks for the patch! I want to run it and the tests to mark it as Ready for Checkin, however, unfortunately, I am unable to apply your patch, because it is not a svn diff. Could you make it into a svn diff?

As far as I know, patches are supplied here as svn diffs at the ticket. Or did I miss something and did this policy change?

Wim

comment:13 Changed 4 years ago by cmheisel

Wim,

Sure thing, I didn't realize they weren't compatible.

I'll generate a plain-ole-diff and resubmit.

Chris

comment:15 Changed 4 years ago by Wim Feijen <wim@…>

  • Triage Stage changed from Accepted to Ready for checkin

Thanks Alex.

Patch and docs are complete, so: ready for check-in.

comment:16 Changed 4 years ago by ramiro

  • Resolution set to fixed
  • Status changed from new to closed

In [16901]:

Fixed #16789 -- Added names to URLs in convenience contrib.auth urls.py.

Thanks wim AT go2people DOT nl for the report, cmheisel for the patch and
fcurella for reviewing it.

Note: See TracTickets for help on using tickets.
Back to Top