id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
16042	comments framework uses uncached content types	Craig de Stigter	nobody	"We found our list views were doing too many database queries for content types, even with caching turned on.

Turns out the comments framework is to blame, for using the uncached method ContentType.objects.get(...)

This one-liner fixes it:

{{{
--- a/django/contrib/comments/templatetags/comments.py
+++ b/django/contrib/comments/templatetags/comments.py
@@ -49,7 +49,7 @@ class BaseCommentNode(template.Node):
     def lookup_content_type(token, tagname):
         try:
             app, model = token.split('.')
-            return ContentType.objects.get(app_label=app, model=model)
+            return ContentType.objects.get_by_natural_key(app, model)
         except ValueError:
             raise template.TemplateSyntaxError(""Third argument in %r must be in the format 'app.model'"" % tagname)
         except ContentType.DoesNotExist:
}}}"	Bug	closed	contrib.comments	dev	Normal	fixed	dceu2011		Ready for checkin	1	0	0	0	0	0