id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
14803	"ModelFormMixing's handling of ""success_url"" is inconsistent with old generic view behaviour"	Gabriel Grant	Gabriel Grant	"Handling of ""success_url"" in ModelFormMixing seems to be inconsistent with how ""get_absolute_url"" is handled in views.generic.create_update.redirect()

In old generic views, the url could be a format string into which the object's fields would be interpolated. But that doesn't happed in ModelFormMixin: form_valid() just redirects to the result of get_success_url() (which doesn't do the interpolation)


This inconsistency should be dealt with by either:

1. documenting the discrepency in [http://docs.djangoproject.com/en/dev/topics/generic-views-migration/ here] (presumably with the suggestion that the reader override the ""get_success_url()"" method to implement the interpolation) 

2. patching ModelFormMixin.get_success_url() to be consistent with old generic view handling and document the behaviour [http://docs.djangoproject.com/en/dev/ref/class-based-views/#modelformmixin here]

I prefer the latter, but the behaviour change could be a design decision (which I'm certainly not qualified to override :). Let me know, and I can prepare a patch.

Also, as an aside, it seems that redirecting back to the POSTed form would be a better last-resort, rather than throwing an ImproperlyConfigured error.

Comments?"		closed	Generic views	dev		fixed			Ready for checkin	1	0	0	0	0	0