id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
13929	ModelForm save in version 1.2.1 not backward compatible due to construct  and exclude args	Margie Roginski	nobody	"I feel like the model validation code has not left a path that allows the modelForm save() to be easily backward compatible with the old 1.1 behavior.  

I would like to avoid doing model validation for my model form, by overriding _post_clean() to be a pass.  I am able to avoid the model validation just fine by doing this, but when I call the modelForm's save() method, it does not save the model form data to the model due to the fact that save() calls save_instance() with the construct argument set to False. 


I understand that the save() code is assuming that I have already constructed by instance, and for that reason it is calling save_instance with construct set to False.  But I think I should be able to override _post_clean with a pass and then have save() still work the way it used to.   It seems like ModelForm's save() method could figure out itself whether construct_instance has already been called, and if it has not been called, called save_instance() with construct set to True.  Additionally, for this to be backward compatible, we'd need to pass the exclude argument to save_instance, as we used to in 1.1.

Currently in order for me to bypass the new model validation, I need to both override _post_clean() with a pass (which I'm happy with), and also override save() such that it looks like this:

{{{

    def save(self, commit=True):

        if self.instance.pk is None:
            fail_message = 'created'
        else:
            fail_message = 'changed'
            
        return save_instance(self, self.instance, self._meta.fields,
                             fail_message, commit, construct=True, exclude=self._meta.exclude)
                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

    save.alters_data = True
        
}}}

It seems like this override of save() could be avoided, allowing 1.2.1 to be backward compatible with 1.1 by just overriding _post_clean() with a pass.

Margie

"		closed	Uncategorized	1.2		invalid			Unreviewed	0	0	0	0	0	0