id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
13743	CommentsAdmin blows up when 'delete_selected' action is disabled.	daniellindsley	nobody	"In our admin, we disable the ``delete_selected`` action due to too many users shooting themselves in the foot. We also have non-superuser accounts that can access the admin.

The ``CommentsAdmin.get_actions`` method assumes various actions will be in the list, but the ``actions.pop`` statements will fail as a result.

Attached is a traceback and a patch.

{{{
Traceback:
File ""/home/code.django-1.0/django/core/handlers/base.py"" in get_response
100. response = callback(request, *callback_args, **callback_kwargs)
File ""/home/code.django-1.0/django/contrib/admin/options.py"" in wrapper
239. return self.admin_site.admin_view(view)(*args, **kwargs)
File ""/home/code.django-1.0/django/utils/decorators.py"" in _wrapped_view
76. response = view_func(request, *args, **kwargs)
File ""/home/code.django-1.0/django/views/decorators/cache.py"" in _wrapped_view_func
69. response = view_func(request, *args, **kwargs)
File ""/home/code.django-1.0/django/contrib/admin/sites.py"" in inner
190. return view(request, *args, **kwargs)
File ""/home/code.django-1.0/django/utils/decorators.py"" in _wrapper
21. return decorator(bound_func)(*args, **kwargs)
File ""/home/code.django-1.0/django/utils/decorators.py"" in _wrapped_view
76. response = view_func(request, *args, **kwargs)
File ""/home/code.django-1.0/django/utils/decorators.py"" in bound_func
17. return func(self, *args2, **kwargs2)
File ""/home/code.django-1.0/django/contrib/admin/options.py"" in changelist_view
955. actions = self.get_actions(request)
File ""/home/code.django-1.0/django/contrib/comments/admin.py"" in get_actions
32. actions.pop('delete_selected')
File ""/home/code.django-1.0/django/utils/datastructures.py"" in pop
123. result = super(SortedDict, self).pop(k, *args)

Exception Type: KeyError at /admin/comments/comment/
Exception Value: 'delete_selected'
}}}
"		closed	contrib.comments	1.3-alpha		fixed			Ready for checkin	1	0	0	0	0	0