id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
12742	File upload handler in Comments framework	Sebastian Żurek	nobody	"I've recently find out some annoying django.contrib.comments limitations-chain. It came out after unsuccessful custom comment form (that included FileField) submission.

This is what I mean by limitations-chain:
----------
A)
I could not use comment model having file field (CommentSeciurityForm does not use *args, **kwargs when supering forms.Form and thus files=request.FILES was not valid __init__ kword argument in forms that base on CommentSeciurityForm)

B)
In consequence comment form post handler (view function named 'post_comment') is not using request.FILES

C)
Which is related with form template issue: check for form.is_multipart is missing (hence multipart/form-data enctype is not set)
-------------

Are those file-handling limitation intentionally created (some security reasons?)? I'm attaching a .diff with some cosmetic changes, that allow for files upload.

While browsing django.contrib.comments code and using the framework in my project I can see there's still some work to be done (there's plenty of room for some generalizations - I found API being nice, however we could make it more flexible with e.g. allowing more than one comment form definition). 

However, to stay focused on one issue: could You please comment this problem (or not) with files?"	New feature	closed	contrib.comments	dev	Normal	wontfix	files		Accepted	1	1	1	0	0	0