id summary reporter owner description type status component version severity resolution keywords cc stage has_patch needs_docs needs_tests needs_better_patch easy ui_ux 12596 Calling ModelForm.clean() is no longer optional Carl Meyer Carl Meyer "It's [[documented http://docs.djangoproject.com/en/1.1/topics/forms/modelforms/#overriding-the-clean-method]] that if you override clean() on a ModelForm and fail to call ModelForm's clean() method, all you lose is validate_unique. With the recent model validation changes, this is no longer true; ModelForm.clean does quite a bit more (including constructing self.instance), and failing to call it will almost certainly break things. Per discussion with jkocherhans in IRC, it should be possible to rearrange things to maintain the previously documented behavior." closed Forms 1.1 fixed ramusus@… Unreviewed 1 0 0 0 0 0