id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
12569	GenericInlineModelAdmin's get_formset method has a non standard signature	Lars van de Kerkhof	nobody	"Unlike InlineModelAdmin GenericInlineModelAdmin does not let you override any values using keyword arguments.

InlineModelAdmin's signature looks like this:


{{{
def get_formset(self, request, obj=None, **kwargs):
}}}

Any keyword arguments passed will override settings in the defaults dict which is constructed inside the function.
This mechanic makes overriding the method while still using some of the standard functionality inside get_formset very streamlined.

If the same is tried with GenericInlineModelAdmin you will have to copy paste the whole function body because this the signature of it's get_formset method:


{{{
def get_formset(self, request, obj=None):
}}}

The defaults object constructed inside the method can not be overriden by passing keyword arguments, meaning you can not reuse any of the functionality in the method when overriding it, using inheritance.

Solution:

Make GenericInlineModelAdmin use the same mechanic as InlineModelAdmin so you can override the defaults object using keyword arguments.

See against current trunk.

"		closed	Uncategorized	1.2-alpha		duplicate	inline get_formset defaults kwargs		Unreviewed	1	0	0	0	0	0