id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
12277	Admin action example should use verbose_name in message_bit	Alex Hayes	nobody	"Within http://docs.djangoproject.com/en/dev/ref/contrib/admin/actions/#actions-as-modeladmin-methods it contains the following example;

{{{
class ArticleAdmin(admin.ModelAdmin):
    ...

    def make_published(self, request, queryset):
        rows_updated = queryset.update(status='p')
        if rows_updated == 1:
            message_bit = ""1 story was""
        else:
            message_bit = ""%s stories were"" % rows_updated
        self.message_user(request, ""%s successfully marked as published."" % message_bit)

}}}

However, a DRY approach would be to use the models meta verbose_name and verbose_name_plural, ie:

{{{
from django.utils.encoding import force_unicode

class ArticleAdmin(admin.ModelAdmin):
    ...

    def make_published(self, request, queryset):
        rows_updated = queryset.update(status='p')
        if rows_updated == 1:
            message_bit = ""1 %s was"" % force_unicode(self.model._meta.verbose_name)
        else:
            message_bit = ""%s %s were"" % (rows_updated, force_unicode(self.model._meta.verbose_name_plural))
        self.message_user(request, ""%s successfully marked as published."" % message_bit)

}}}

That is of course unless there is a better way of doing this with a method?"		closed	Documentation	dev		wontfix	admin action		Unreviewed	0	0	0	0	0	0