id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
11191	Admin throws 500 instead of 404 error when passing a string as the PK argument for a model with an integer PK field.	Tai Lee	Chris Beaven	"The situation where a PK of the incorrect type (string instead of integer) is specified in an admin URL is probably very rare, as most people will only ever navigate to the add/change form via the admin which hopefully generates a correct link, or at least the user types in a PK of the correct type (even if no object exists with that PK). I only discovered this through another bug in my code that was making requests to URLs that don't exist, e.g. `/admin/transfers/booking/global.css/`.

Such a request *should* return a 404 File Not Found error. Even though the PK is of an incorrect type, the URL does not exist, rather than exists but encounters a fatal exception. The error is easy to reproduce. Just fire up the admin, navigate to any model which expects an integer PK (e.g. `/admin/auth/user/1/`) and change the PK to a string (e.g. `/admin/auth/user/abc/`).

The exception that is generated is:

{{{
Environment:

Request Method: GET
Request URL: http://localhost:8000/admin/auth/user/abc/
Django Version: 1.1 beta 1 SVN-10838
Python Version: 2.4.6
Installed Applications:
['django.contrib.admin',
 'django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.sessions',
 'django.contrib.sites']
Installed Middleware:
('django.middleware.common.CommonMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware')


Traceback:
File ""/path/to/django/core/handlers/base.py"" in get_response
  92.                 response = callback(request, *callback_args, **callback_kwargs)
File ""/path/to/django/contrib/admin/options.py"" in wrapper
  226.                 return self.admin_site.admin_view(view)(*args, **kwargs)
File ""/path/to/django/contrib/admin/sites.py"" in inner
  184.             return view(request, *args, **kwargs)
File ""/path/to/django/db/transaction.py"" in _commit_on_success
  240.                 res = func(*args, **kw)
File ""/path/to/django/contrib/admin/options.py"" in change_view
  792.             obj = self.queryset(request).get(pk=unquote(object_id))
File ""/path/to/django/db/models/query.py"" in get
  268.         clone = self.filter(*args, **kwargs)
File ""/path/to/django/db/models/query.py"" in filter
  466.         return self._filter_or_exclude(False, *args, **kwargs)
File ""/path/to/django/db/models/query.py"" in _filter_or_exclude
  484.             clone.query.add_q(Q(*args, **kwargs))
File ""/path/to/django/db/models/sql/query.py"" in add_q
  1665.                             can_reuse=used_aliases)
File ""/path/to/django/db/models/sql/query.py"" in add_filter
  1608.                 connector)
File ""/path/to/django/db/models/sql/where.py"" in add
  56.                 obj, params = obj.process(lookup_type, value)
File ""/path/to/django/db/models/sql/where.py"" in process
  269.                 params = self.field.get_db_prep_lookup(lookup_type, value)
File ""/path/to/django/db/models/fields/__init__.py"" in get_db_prep_lookup
  210.             return [self.get_db_prep_value(value)]
File ""/path/to/django/db/models/fields/__init__.py"" in get_db_prep_value
  361.         return int(value)

Exception Type: ValueError at /admin/auth/user/abc/
Exception Value: invalid literal for int(): abc
}}}

This bug is present in Django version 1.1 beta 1 SVN-10838.

"		closed	contrib.admin	dev		fixed	admin urls pk integer ValueError		Ready for checkin	1	0	0	0	0	0