id summary reporter owner description type status component version severity resolution keywords cc stage has_patch needs_docs needs_tests needs_better_patch easy ui_ux 10677 post_save_moderation breaks confirmation view nate-django@… nobody "I tried out the new moderation tools and I found that when a comment is deleted in the post_save signal handler post_save_moderation(), it breaks the comment confirmation view because the comment instance is gone and _get_pk_val() returns None. This causes the following traceback for the redirected request. {{{ File ""/var/lib/python-support/python2.5/django/core/handlers/base.py"" in get_response 86. response = callback(request, *callback_args, **callback_kwargs) File ""/var/lib/python-support/python2.5/django/contrib/comments/views/utils.py"" in confirmed 41. comment = comments.get_model().objects.get(pk=request.GET['c']) File ""/var/lib/python-support/python2.5/django/db/models/manager.py"" in get 93. return self.get_query_set().get(*args, **kwargs) File ""/var/lib/python-support/python2.5/django/db/models/query.py"" in get 303. clone = self.filter(*args, **kwargs) File ""/var/lib/python-support/python2.5/django/db/models/query.py"" in filter 489. return self._filter_or_exclude(False, *args, **kwargs) File ""/var/lib/python-support/python2.5/django/db/models/query.py"" in _filter_or_exclude 507. clone.query.add_q(Q(*args, **kwargs)) File ""/var/lib/python-support/python2.5/django/db/models/sql/query.py"" in add_q 1258. can_reuse=used_aliases) File ""/var/lib/python-support/python2.5/django/db/models/sql/query.py"" in add_filter 1201. self.where.add((alias, col, field, lookup_type, value), connector) File ""/var/lib/python-support/python2.5/django/db/models/sql/where.py"" in add 48. params = field.get_db_prep_lookup(lookup_type, value) File ""/var/lib/python-support/python2.5/django/db/models/fields/__init__.py"" in get_db_prep_lookup 202. return [self.get_db_prep_value(value)] File ""/var/lib/python-support/python2.5/django/db/models/fields/__init__.py"" in get_db_prep_value 353. return int(value) Exception Type: ValueError at /comments/posted/ Exception Value: invalid literal for int() with base 10: 'None' }}} Shouldn't moderation.py connect to the comment_will_be_posted signal so post_comment() can handle the signal response?" new contrib.comments 1.1-beta Accepted 0 0 0 0 0 0