Consistency between HttpResponse* params and render_to_response

[Brent Hagany]

I was just browsing through some of the Django code and came across the new-ish (to me) addition of the content_type alias for the mimetype parameter to HttpResponse and company. Wondering about the rationale behind this decision, I came across ticket #3526, which may be helpful to review in evaluating this ticket.

In light of this, (and just for consistency) I thought it would probably be a good idea to allow render_to_response to pass content_type along to HttpResponse. I'll attach a simple patch that does this.

Also, this patch will conflict with another patch (#9081) I've submitted that has been accepted but not yet committed. It'll be very easy to resolve, but I'm unsure if I should take any special measures about this.

[Roland van Laar]

Needs tests.

[Brent Hagany]

My initial reaction - really?

1) Nobody has found it necessary to write a single test for a shortcut before (unless I just don't understand where they would be)
2) This is less than a one line change
3) This ticket has been touched by a core committer and accepted, despite the absence of tests.

So, I mean, I can do this. But because of these things, I had been working under the assumption that it was not necessary. Please advise.

[ccahoon]

@bhagany As I understand it, "Accepted" means that he thinks the general idea of the ticket is valid, not that the patch is accepted. If the patch was accepted, jacob would have committed the changes. I think it's a fine patch, though. I found this ticket looking to see if someone had already done the work I was about to on my GSoC branch, and there yours is. I am going to apply your changes to my SoC branch, so it will be bound to get reviewed within a month or so.

[ccahoon]

@bhagany Actually, I will probably spend some time hopping between the two patches you've submitted and get advice from my mentor. They both look good, but the other is indeed very flexible, and I don't see any problems with it yet.

[Brent Hagany]

@ccahoon Sounds great! I've been following the work in your branch, and I'm happy to have saved you a teensy bit of work.

Also, re: accepted status - noted, and thanks for explaining.

[Chris Beaven]

ccahoon: have you fixed this in your branch? (if so, update the triage stage)

[kenth]

Added tests for new shortcut.

[anonymous]

In [da200c5e35cd] (in response to ticket #16519 ) mimetype has been deprecated, so the patch isn't anymore needed.

[Riccardo Attilio Galli]

I sat the resolution to invalid erroneously as anonymous, ccing now to follow evenctual future messages

[Claude Paroz]

In [da200c5e35cd], we didn't address the render_to_response inconsistency, so I think that the attached patch still makes sense. We should however introduce a deprecation path for the mimetype argument also.

[Tim Graham]

Deprecating of mimetype in render_to_response completed in #19692 and 89cb771be7b53c40642872cdbedb15943bdf8e34.