Ticket #9029: 9029-get-or-create-r14733.diff

django/db/models/query.py

@@ -369 +369 @@
         assert kwargs, \
                 'get_or_create() must be passed at least one keyword argument'
         defaults = kwargs.pop('defaults', {})
+        lookup = kwargs.copy()
+        for f in self.model._meta.fields:
+            if f.column in lookup:
+                lookup[f.name] = lookup.pop(f.column)
         try:
             self._for_write = True
-            return self.get(**kwargs), False
+            return self.get(**lookup), False
         except self.model.DoesNotExist:
             try:
                 params = dict([(k, v) for k, v in kwargs.items() if '__' not in k])
@@ -384 +388 @@
             except IntegrityError, e:
                 transaction.savepoint_rollback(sid, using=self.db)
                 try:
-                    return self.get(**kwargs), False
+                    return self.get(**lookup), False
                 except self.model.DoesNotExist:
                     raise e
 

tests/regressiontests/get_or_create_regress/tests.py

@@ -21 +21 @@
         # Add an author to the book.
         ed, created = book.authors.get_or_create(name="Ed")
         self.assertTrue(created)
-        # Book should have one author.
+        # The book should have one author.
         self.assertEqual(book.authors.count(), 1)
 
         # Try get_or_create again, this time nothing should be created.
@@ -51 +51 @@
         # Now Ed has two Books, Fred just one.
         self.assertEqual(ed.books.count(), 2)
         self.assertEqual(fred.books.count(), 1)
+
+        # Use the publisher's primary key value instead of a model instance.
+        _, created = ed.books.get_or_create(name='The Great Book of Ed', publisher_id=p.id)
+        self.assertTrue(created)
+        # Try get_or_create again, this time nothing should be created.
+        _, created = ed.books.get_or_create(name='The Great Book of Ed', publisher_id=p.id)
+        self.assertFalse(created)
+        # The publisher should have three books.
+        self.assertEqual(p.books.count(), 3)