Ticket #8882: formset-unique.diff

django/forms/models.py

@@ -377 +377 @@
                     form.save_m2m()
             self.save_m2m = save_m2m
         return self.save_existing_objects(commit) + self.save_new_objects(commit)
+    
+    def clean(self):
+        self.validate_unique()
+    
+    def validate_unique(self):
+        from django.db.models.fields import FieldDoesNotExist
+        unique_checks = []
+        for name, field in self.forms[0].fields.iteritems():
+            try:
+                f = self.forms[0].instance._meta.get_field_by_name(name)[0]
+            except FieldDoesNotExist:
+                continue
+            if f.unique:
+                unique_checks.append((name,))
+        
+        bad_fields = set()
+        for unique_check in unique_checks:
+            if len(unique_check) == 1:
+                field = unique_check[0]
+                data = set()
+                for i in xrange(self._total_form_count):
+                    form = self.forms[i]
+                    if hasattr(form, 'cleaned_data') and field in form.cleaned_data and form.cleaned_data[field] is not None:
+                        if form.cleaned_data[field] in data:
+                            bad_fields.add(unique_check)
+                        else:
+                            data.add(form.cleaned_data[field])
+        
+        if bad_fields:
+            errors = []
+            for field in bad_fields:
+                errors.append(_(u"You have entered duplicate data for %(field)s, all %(field)ss should be unique" % {
+                        'field': get_text_list(field, _(u'and'))
+                    }))
+            raise ValidationError(errors)
 
     def save_existing_objects(self, commit=True):
         self.changed_objects = []

tests/modeltests/model_formsets/models.py

@@ -727 +727 @@
 >>> formset.get_queryset()
 [<Player: Bobby>]
 
+# Prevent duplicates from within the same formset
+>>> FormSet = modelformset_factory(Product, extra=2)
+>>> data = {
+...     'form-TOTAL_FORMS': 2,
+...     'form-INITIAL_FORMS': 0,
+...     'form-0-slug': 'red_car',
+...     'form-1-slug': 'red_car',
+... }
+>>> formset = FormSet(data)
+>>> formset.is_valid()
+False
+>>> formset._non_form_errors
+[u'You have entered duplicate data for slug, all slugs should be unique']
 """}