Ticket #5959: boolean_hidden.diff

django/newforms/fields.py

@@ -538 +538 @@
     def clean(self, value):
         "Returns a Python boolean object."
         super(BooleanField, self).clean(value)
-        # Explicitly check for the string '0', which is what as hidden field
+        # Explicitly check for the string 'False', which is what as hidden field
         # will submit for False.
-        if value == '0':
+        if value == 'False':
             return False
         return bool(value)
 

tests/regressiontests/forms/fields.py

@@ -914 +914 @@
 >>> f.clean('Django rocks')
 True
 
+A form's BooleanField with a hidden widget will output the string 'False', so
+that should clean to the boolean value False:
+>>> f.clean('False')
+False
+
 >>> f = BooleanField(required=False)
 >>> f.clean('')
 False
@@ -930 +935 @@
 >>> f.clean('Django rocks')
 True
 
+A form's BooleanField with a hidden widget will output the string 'False', so
+that should clean to the boolean value False:
+>>> f.clean('False')
+False
+
 # ChoiceField #################################################################
 
 >>> f = ChoiceField(choices=[('1', '1'), ('2', '2')])

tests/regressiontests/forms/widgets.py

@@ -128 +128 @@
 >>> w.render('email', '', attrs={'class': 'special'})
 u'<input type="hidden" class="special" name="email" />'
 
+Still renders the boolean value False as the string 'False', it's the job of the
+field to clean that back to a boolean False if required.
+>>> w = HiddenInput()
+>>> w.render('get_spam', False)
+u'<input type="hidden" name="get_spam" value="False" />'
+
 # MultipleHiddenInput Widget ##################################################
 
 >>> w = MultipleHiddenInput()