Ticket #21740: client_mutable_argument_fix_02.patch

django/test/client.py

@@ -276 +276 @@
             path = path.encode('utf-8').decode('iso-8859-1')
         return path
 
-    def get(self, path, data={}, secure=False, **extra):
+    def get(self, path, data=None, secure=False, **extra):
         "Construct a GET request."
 
+        if not data:
+          data = {}
+
         r = {
             'QUERY_STRING': urlencode(data, doseq=True),
         }
         r.update(extra)
         return self.generic('GET', path, secure=secure, **r)
 
-    def post(self, path, data={}, content_type=MULTIPART_CONTENT,
+    def post(self, path, data=None, content_type=MULTIPART_CONTENT,
              secure=False, **extra):
         "Construct a POST request."
 
+        if not data:
+            data = {}
+
         post_data = self._encode_data(data, content_type)
 
         return self.generic('POST', path, post_data, content_type,
                             secure=secure, **extra)
 
-    def head(self, path, data={}, secure=False, **extra):
+    def head(self, path, data=None, secure=False, **extra):
         "Construct a HEAD request."
 
+        if not data:
+            data= {}
+
         r = {
             'QUERY_STRING': urlencode(data, doseq=True),
         }
@@ -460 +469 @@
             signals.template_rendered.disconnect(dispatch_uid=signal_uid)
             got_request_exception.disconnect(dispatch_uid="request-exception")
 
-    def get(self, path, data={}, follow=False, secure=False, **extra):
+    def get(self, path, data=None, follow=False, secure=False, **extra):
         """
         Requests a response from the server using GET.
         """
@@ -470 +479 @@
             response = self._handle_redirects(response, **extra)
         return response
 
-    def post(self, path, data={}, content_type=MULTIPART_CONTENT,
+    def post(self, path, data=None, content_type=MULTIPART_CONTENT,
              follow=False, secure=False, **extra):
         """
         Requests a response from the server using POST.
@@ -482 +491 @@
             response = self._handle_redirects(response, **extra)
         return response
 
-    def head(self, path, data={}, follow=False, secure=False, **extra):
+    def head(self, path, data=None, follow=False, secure=False, **extra):
         """
         Request a response from the server using HEAD.
         """

tests/test_client/tests.py

@@ -65 +65 @@
         self.assertTemplateNotUsed(response, 'Empty GET Template')
         self.assertTemplateUsed(response, 'Empty POST Template')
 
+    def test_no_post(self):
+        "POST an empty dictionary to a view"
+        response = self.client.post('/test_client/post_view/')
+
+        # Check some response details
+        self.assertEqual(response.status_code, 200)
+        self.assertEqual(response.templates[0].name, 'Empty POST Template')
+        self.assertTemplateNotUsed(response, 'Empty GET Template')
+        self.assertTemplateUsed(response, 'Empty POST Template')
+
     def test_post(self):
         "POST some data to a view"
         post_data = {