Ticket #18533: makemessages.patch

File makemessages.patch, 1.1 KB (added by pasha.savchenko@…, 3 years ago)

A patch to fix makemessages issue on windows

  • django/core/management/commands/makemessages.py

    From 3ff10662f6926b208fb5eb90effb7f536b236a37 Mon Sep 17 00:00:00 2001
    From: Pavel Savchenko <pasha.savchenko@gmail.com>
    Date: Fri, 14 Sep 2012 23:40:30 +0300
    Subject: [PATCH] Remove redundant `shell=True` parameter for Popen
    
    Fixes [ticket #18533 - makemessages command fails on windows](https://code.djangoproject.com/ticket/18533).
    More info in the issue in the ticket
    ---
     django/core/management/commands/makemessages.py |    2 +-
     1 file changed, 1 insertion(+), 1 deletion(-)
    
    diff --git a/django/core/management/commands/makemessages.py b/django/core/management/commands/makemessages.py
    index 0b75059..ec8a8df 100644
    a b def _popen(cmd): 
    4242    """
    4343    Friendly wrapper around Popen for Windows
    4444    """
    45     p = Popen(cmd, shell=True, stdout=PIPE, stderr=PIPE, close_fds=os.name != 'nt', universal_newlines=True)
     45    p = Popen(cmd, stdout=PIPE, stderr=PIPE, close_fds=os.name != 'nt', universal_newlines=True)
    4646    return p.communicate()
    4747
    4848def walk(root, topdown=True, onerror=None, followlinks=False,
Back to Top