Ticket #14796: 14796-move_keyword_check_with_tests.diff

django/core/management/commands/inspectdb.py

@@ -20 +20 @@
     def handle_noargs(self, **options):
         try:
             for line in self.handle_inspection(options):
-                print line
+                self.stdout.write("%s\n" % line)
         except NotImplementedError:
             raise CommandError("Database inspection isn't supported for the currently selected database backend.")
 
@@ -66 +66 @@
                 if ' ' in att_name:
                     att_name = att_name.replace(' ', '_')
                     comment_notes.append('Field renamed to remove spaces.')
+                    
                 if '-' in att_name:
                     att_name = att_name.replace('-', '_')
                     comment_notes.append('Field renamed to remove dashes.')
-                if keyword.iskeyword(att_name):
-                    att_name += '_field'
-                    comment_notes.append('Field renamed because it was a Python reserved word.')
+                    
                 if column_name != att_name:
                     comment_notes.append('Field name made lowercase.')
 
@@ -97 +96 @@
                             extra_params['unique'] = True
 
                     field_type += '('
+                    
+                if keyword.iskeyword(att_name):
+                    att_name += '_field'
+                    comment_notes.append('Field renamed because it was a Python reserved word.')
 
                 # Don't output 'id = meta.AutoField(primary_key=True)', because
                 # that's assumed if it doesn't exist.

tests/regressiontests/inspectdb/tests.py

@@ +1 @@
+import os
+import sys
+from StringIO import StringIO
+
+from django.conf import settings
+from django.core.management import call_command
+from django.db.models.loading import load_app
+from django.test import TestCase
+
+class InspectDBTestCase(TestCase):
+    
+    def setUp(self):
+        self.old_sys_path = sys.path[:]
+        sys.path.append(os.path.dirname(os.path.abspath(__file__)))
+        self.old_installed_apps = settings.INSTALLED_APPS
+        settings.INSTALLED_APPS = ('bug',)
+        map(load_app, settings.INSTALLED_APPS)
+        call_command('syncdb', verbosity=0)
+        
+    def test_attribute_name_not_python_keyword(self):
+        out = StringIO()
+        call_command('inspectdb', stdout=out)
+        error_message = "inspectdb generated an attribute name which is a python keyword"
+        self.assertNotIn("from = models.ForeignKey(BugPeople)", out.getvalue(), msg=error_message)
+        out.close()
+        
+    def tearDown(self):
+        settings.INSTALLED_APPS = self.old_installed_apps
+        sys.path = self.old_sys_path

tests/regressiontests/inspectdb/bug/models.py

@@ +1 @@
+from django.db import models
+
+class People(models.Model):
+    name = models.CharField(max_length=255)
+
+class Message(models.Model):
+    from_field = models.ForeignKey(People, db_column='from_id')