Changes between Version 8 and Version 9 of CookBookCategoryDataModel

Timestamp:

Aug 21, 2005, 7:28:48 AM (19 years ago)

Author:

aCC

Comment:

fixed code so that moving categories works correctly. had to change search_fields et. al. Hope that doesn't lose functionality.

CookBookCategoryDataModel

@@ -13 +13 @@
     fields = (
         meta.CharField('category_name', maxlength=50),
-        meta.CharField('category_parents', maxlength=250, editable=False),
-        meta.ForeignKey('self', blank=True, null=True, 
+        meta.ForeignKey('self', blank=True, null=True,
             rel_name='parent', related_name='child'),
+        meta.ForeignKey(User)
     )
-    unique_together = (("category_name", "category_parents"),)
 
     def _recurse_for_parents(self, cat_obj):
@@ -27 +26 @@
             p_list.extend(more)
         if cat_obj == self and p_list:
-
             p_list.reverse()
         return p_list
@@ -37 +35 @@
         p_list = self._recurse_for_parents(self)
         return self.get_separator().join(p_list)
+    _parents_repr.short_description = "Category parents"
 
     def __repr__(self):
-        if self.category_parents:
-            l = [self.category_parents, self.category_name]
-            return self.get_separator().join(l)
-        return self.category_name
-
-    def _pre_save(self):
-        self.category_parents = self._parents_repr()
+        p_list = self._recurse_for_parents(self)
+        p_list.append(self.category_name)
+        return self.get_separator().join(p_list)
 
     admin = meta.Admin(
-        list_display = ('category_name', 'category_parents'),
-        search_fields = ['category_name', 'category_parents'],
+        list_display = ('category_name', '_parents_repr'),
+        search_fields = ['category_name'],
     )
-    ordering = ('category_parents', 'category_name')
 }}}
 
@@ -119 +113 @@
 http://www.djangoproject.com/documentation/models/m2o_recursive/
 
-== Comments ==
-
-This example has a bug: the field "category_parents" gets not updated, if a parent category was moved. 
-
-E.g. you create the following categories:
-{{{
-firstcat
-secondcat
-secondcat :: thirdcat
-}}}
-
-
-Now you move "secondcat" under "firstcat". The correct display would be:
-{{{
-firstcat
-firstcat :: secondcat
-firstcat :: secondcat :: thirdcat
-}}}
-
-
-But because "category_parents" of thirdcat was not updated, you see:
-{{{
-firstcat
-firstcat :: secondcat
-secondcat :: thirdcat
-}}}
-
-
-In the database it is correct, just the display is incorrect.
-
-Can anybody fix this?