Changes between Initial Version and Version 1 of Ticket #9245, comment 15


Ignore:
Timestamp:
Jul 7, 2012, 6:40:36 PM (12 years ago)
Author:
David Gouldin

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #9245, comment 15

    initial v1  
    1 Julien, this patch will not work as-is. Your new Field.choices_formfield function is called from Field.formfield using **defaults, but defaults will never include form_class. This means that Field.choices_formfield will always be called with its default value for form_class (None unless overridden by a custom Field subclass) even when the user's intent was to provide a custom form_class for that model field. So for this model:
     1Julien, this patch will not work as-is. Your new Field.choices_formfield function is called from Field.formfield using !**defaults, but defaults will never include form_class. This means that Field.choices_formfield will always be called with its default value for form_class (None unless overridden by a custom Field subclass) even when the user's intent was to provide a custom form_class for that model field. So for this model:
    22
    33{{{
    … …  
    88MyCustomFormClass would never make it to bar's Field.choices_formfield, and so an instance of it would not be returned by Field.formfield.
    99
    10 However, it also not work to simply call self.choices_formfield(form_class=form_class, **defaults) from Field.formfield. Subclasses of Field (such as IntegerField) frequently override formfield() and call super's formfield() with a form_class kwarg. This means that calling Field.choices_formfield with Field.formfield's form_class would break models like this:
     10However, it also not work to simply call self.choices_formfield(form_class=form_class, !**defaults) from Field.formfield. Subclasses of Field (such as IntegerField) frequently override formfield() and call super's formfield() with a form_class kwarg. This means that calling Field.choices_formfield with Field.formfield's form_class would break models like this:
    1111
    1212
Back to Top