Opened 16 years ago
Last modified 13 years ago
#8459 closed
get_or_create does not pay attention to the instance calling it — at Initial Version
Reported by: | mymmaster | Owned by: | nobody |
---|---|---|---|
Component: | Database layer (models, ORM) | Version: | dev |
Severity: | Keywords: | get_or_create aug22sprint | |
Cc: | farhan@… | Triage Stage: | Design decision needed |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
get_or_create can be confusing to use because it doesn't pay attention to the object that is actually calling it. For example when calling
forumpost.participant_set.get_or_create(user=person)
it would make sense that get_or_create is referencing participant_set that is calling it and therefore would create a new entry to that result set if it doesn't exist. However, this is not the case. get_or_create merely uses participant_set to determine the type of object it is dealing with.