Opened 16 years ago
Last modified 16 years ago
#8005 closed
Make it easier to alter a model saved by the admin (e.g. add the user that created or updated it) — at Version 1
Reported by: | simon | Owned by: | nobody |
---|---|---|---|
Component: | contrib.admin | Version: | dev |
Severity: | Keywords: | ||
Cc: | Triage Stage: | Design decision needed | |
Has patch: | yes | Needs documentation: | yes |
Needs tests: | yes | Patch needs improvement: | yes |
Easy pickings: | no | UI/UX: | no |
Description (last modified by )
A very common requirement for customising the admin is to automatically update a created_by or updated_by field with the user object that made changes to an object. This is currently way harder than it should be: http://www.djangosnippets.org/snippets/903/
I propose adding an extra subclassable method that makes it trivial to intercept the model as it is being created and perform additional work on it. Here's an example (incomplete) patch illustrating the idea: http://code.djangoproject.com/attachment/ticket/8005/8005.1.diff
This would allow ModelAdmin subclasses to make additional changes to the model by calling form.save(commit=False) instead. For the admin user described above, the subclass would look like this:
class ArticleAdmin(admin.ModelAdmin): def save_model_add(self, request, form, formsets): new_object = form.save(commit=False) new_object.created_by = request.user new_object.updated_by = request.user new_object.save() if formsets: for formset in formsets: formset.instance = new_object formset.save() return new_object def save_model_change(self, request, form, formsets): new_object = form.save(commit=False) new_object.updated_by = request.user new_object.save() if formsets: for formset in formsets: formset.save() return new_object
This is a big improvement, although I'm not too happy with the need to duplicate the formset logic. Maybe that should be split out in to a separate over-ridable method as well.
Change History (3)
by , 16 years ago
Attachment: | 8005.1.diff added |
---|
comment:1 by , 16 years ago
Description: | modified (diff) |
---|
by , 16 years ago
Attachment: | 8005.2.diff added |
---|
Improved patch; refactored formset boilerplate in to a separate method