Opened 16 years ago
Last modified 13 years ago
#7483 closed
[newforms-admin] Delete view doesn't link to related objects — at Version 1
| Reported by: | Owned by: | nobody | |
|---|---|---|---|
| Component: | contrib.admin | Version: | newforms-admin |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
The get_deleted_objects function in django.contrib.admin.util lists the related objects that will be affected by a delete operation. It contains code to link each item to its actual admin page. However, this is never called because in order to check if the model has an admin page, it checks has_admin = related.__class__ in admin_site._registry - but related.__class__ is always <class 'django.db.models.related.RelatedObject'>, which naturally does not match anything in _registry. This needs to be changed to related.model, which does work.
Patch includes this change, plus big changes to the admin_views regression test and fixture to set up a related model to test this against.
Change History (2)
by , 16 years ago
| Attachment: | delete_related.diff added |
|---|
comment:1 by , 16 years ago
| Description: | modified (diff) |
|---|
Note:
See TracTickets
for help on using tickets.
Patch and updated tests/fixtures