id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
5388	[newforms-admin] - validation is broken for sites with more than one inline formsets	Petr Marhoun <petr.marhoun@…>	jkocherhans	"Validation of inline formsets is done with this code:

{{{
#!python

def all_valid(formsets):
    """"""Returns true if every formset in formsets is valid.""""""
    valid = True
    for formset in formsets:
        if not formset.is_valid():
            return False

}}}

But method formset.is_valid has side-effect - it calls formset.clean_all and method clean_all resets all unused inline formset. But if first formset is invalid, forms in the second formset aren't reset.

This code works (attached patch changes it):

{{{
#!python

def all_valid(formsets):
    """"""Returns true if every formset in formsets is valid.""""""
    valid = True
    for formset in formsets:
        if not formset.is_valid():
            valid = False
    return valid

}}}
"		closed	Forms	newforms-admin		fixed	newforms, admin, inlines		Ready for checkin	1	0	0	0	0	0