SuccessMessageMixin doesn't work with LoginView

[Cihat Ertem]

I have a problem with SuccessMessageMixin, LoginView. There is no problem with CreateView:

class CreateRoom(SuccessMessageMixin, CreateView):
    template_name = 'base/room_form.html'
    form_class = RoomForm
    success_url = reverse_lazy('home')
    success_message = 'Message'

I can capture and use 'Message' in template but with LoginView

class Login(SuccessMessageMixin, LoginView):
    template_name = 'registration/login.html'
    success_url = reverse_lazy('home')
    success_message = 'Message!!!'

I can not capture 'Message' with LoginView.

[Baptiste Mispelon]

Hi,

Thanks for reporting this issue. I've taken the liberty to edit your original report to remove information that I don't think is relevant, I hope that's ok.

The issue comes from the fact that LoginView.form_valid() doesn't call super():

    def form_valid(self, form):
        """Security check complete. Log the user in."""
        auth_login(self.request, form.get_user())
        return HttpResponseRedirect(self.get_success_url())

I can't find a documented reason why and changing it to this doesn't break any tests:

    def form_valid(self, form):
        """Security check complete. Log the user in."""
        auth_login(self.request, form.get_user())
        return super().form_valid(form)

That change should fix the reported issue and seems straightforward enough.