Changes between Initial Version and Version 1 of Ticket #31210, comment 4


Ignore:
Timestamp:
Jan 29, 2020, 11:59:12 AM (5 years ago)
Author:
Collin Anderson

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #31210, comment 4

    initial v1  
    1 I'm just thinking if someone's trying to upgrade their app to use a new version of django, the most minimal change with the least chance of bugs would be to replace it with `request.META.get('HTTP_X_REQUESTED_WITH') == 'XMLHttpRequest'`. Sure, they could refactor their app so it uses `.accepts()`, but that's a bigger change (which could involve making changes on the front end, which might be a whole different team responsibly for it) and they're just trying to upgrade django right now.
     1I'm just thinking if someone's trying to upgrade their app to use a new version of django, the most minimal change with the least chance of bugs would be to replace it with `request.META.get('HTTP_X_REQUESTED_WITH') == 'XMLHttpRequest'` (or a separate function/method that does exactly that). Sure, they could refactor their app so it uses `.accepts()`, but that's a bigger change (which could involve making changes on the front end, which might be a whole different team responsibly for it) and they're just trying to upgrade django right now.
    22
    33> Do you think that we should be so detailed and document the is_ajax() implementation in release notes? I'm not sure.
Back to Top