id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
28943	Unenforce manual get_context_data()	James Pic	nobody	"Currently, TemplateView inherits render_to_response(context) from TemplateResponseMixin which requires a context argument.

This means that when your TemplateView subclass wants to return the TemplateResponse with the default context, you still have to create and pass the default context:

{{{

class YourView(TemplateView):
    def post(self, request, *a, **k):
        if not self.dostuff():
            return http.HttpResponseBadRequest()

        context = self.get_context_data(*k)
        return self.render_to_response(context)

}}}

The reason for this is that ContentMixin defines get_context_data(), and TemplateResponseMixin defines render_to_response(context, ...), TemplateResponse mixes the two in get():

{{{
class TemplateView(TemplateResponseMixin, ContextMixin, View):
    """"""
    Render a template. Pass keyword arguments from the URLconf to the context.
    """"""
    def get(self, request, *args, **kwargs):
        context = self.get_context_data(**kwargs)
        return self.render_to_response(context)
}}}

I think it would be more usable as such:


{{{
class TemplateView(TemplateResponseMixin, ContextMixin, View):
    """"""
    Render a template. Pass keyword arguments from the URLconf to the context.
    """"""
    def get(self, request, *args, **kwargs):
        return self.render_to_response(**kwargs)

    def render_to_response(self, context=None, **kwargs):
        context = context or self.get_context_data(**kwargs)
        return self.render_to_response(context)
}}}

Then, users could call render_to_response() in their code, ie: 

{{{

class YourView(TemplateView):
    def get(self, request, *a, **k):
        self.token = self.generatetoken()
        return self.render_to_response(**k)

    def post(self, request, *a, **k):
        if not self.dostuff():
            return http.HttpResponseBadRequest()
        return self.render_to_response(**k)
}}}"	Cleanup/optimization	new	Generic views	2.0	Normal				Unreviewed	0	0	0	0	0	0