ModelMultipleChoiceField does not properly check if value is valid

[mattias.lindvall@…]

ModelMultipleChoiceField does try to check if value is valid by doing a query here: ​https://github.com/django/django/blob/stable/1.6.x/django/forms/models.py#L1185

However, it only cathes ValueError, assuming that filter() is capable of even using the value.
If the value is a weird data type like list or dict, the call to filter throws TypeError.
ModelMultipleChoiceField.clean should catch TypeError, in addition to ValueError, on line 1187.

Here is gist with a complete minimal app that demonstrates how this can happen: ​https://gist.github.com/thnee/8e7c6b22f350582efe57/
Specifically the file: 4. views.py.

It is tested with 1.6.5, using 100% default settings in a clean test project.

[Baptiste Mispelon]

Hi,

Looking at django/forms/fields.py, it seems that there is precedent for catching (ValueError, TypeError) so I think it makes sense.

The same error seems to be present in ModelChoiceField so both should be fixed as part of this ticket.

Thanks.

[anonymous]

Created pull request: ​https://github.com/django/django/pull/2813

[Tim Graham]

It needs a test (or tests). Please uncheck "Needs tests" if you can update it, thanks.

[Niclas Olofsson]

New PR with the existing patch applied and including test cases.
​https://github.com/django/django/pull/2964

[Tim Graham <timograham@…>]

In cdc25ac4747bf5a6cdc2e70461c2d43c54529d35:

Fixed #22808 -- Made ModelMultipleChoiceField validation more robust to invalid data types..

Thanks Mattias Lindvall for the report and inital patch.