regressiontests.mail.tests.MailTests.test_dont_base64_encode() fails with Python >=3.3.3

[Arfrever]

regressiontests.mail.tests.MailTests.test_dont_base64_encode() fails with Python >=3.3.3 since ​Python commit 64e004737837.
It passes with older versions of Python.
I use Django 1.5.3.

$ PYTHONPATH="." python3.3 tests/runtests.py --settings=test_sqlite -v0 mail.MailTests.test_dont_base64_encode
======================================================================
FAIL: test_dont_base64_encode (regressiontests.mail.tests.MailTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/Django-1.5.3/tests/regressiontests/mail/tests.py", line 330, in test_dont_base64_encode
    self.assertTrue(str('Content-Transfer-Encoding: 8bit') in s)
AssertionError: False is not True

----------------------------------------------------------------------
Ran 1 test in 0.025s

FAILED (failures=1)

Variable 's' contains 'Content-Transfer-Encoding: 8bit' with older versions of Python and 'Content-Transfer-Encoding: 7bit' with Python >=3.3.3.

[Florian Apolloner]

I think get_payload in python shouldn't decode the message, I am in contact with the author of the patch, hopefully we can get that fixed for python 3.3.3 :)

[Florian Apolloner]

Waiting for the outcome of ​http://bugs.python.org/issue19063

[Florian Apolloner]

We should review if our smtp backend properly sends mails on python 3.3+

[Florian Apolloner <florian@…>]

In f28ea0230846c81e9b6725454bb3a10df24678aa:

Fixed #21093 -- Ensured that mails are not base64 encoded on python 3.3.3+.

Thanks to Arfrever for the report and Aymeric for the review.

[Florian Apolloner <florian@…>]

In 280c1a65ccacd679bf298bf2b169ff01e7266b8e:

Worked around a bug in python 3.3.3. Refs #21093

[Florian Apolloner <florian@…>]

In 35a447a263115b22a7040a9f4a16ff4bd2078466:

[1.6.x] Fixed #21093 -- Ensured that mails are not base64 encoded on python 3.3.3+.

Thanks to Arfrever for the report and Aymeric for the review.

Backport of f28ea0230846c81e9b6725454bb3a10df24678aa from master.

[Florian Apolloner <florian@…>]

In ed167e53a52af22a8dce229696184b0d87a88a78:

[1.6.x] Worked around a bug in python 3.3.3. Refs #21093

Backport of 280c1a65ccacd679bf298bf2b169ff01e7266b8e from master.

[cainmatt@…]

regarding message.py:

I think that rather than re-encoding the message in SafeMimeText you should set the encoding globally for python using:

Charset.add_charset('utf-8', Charset.SHORTEST, None, 'utf-8')

Note:

u1 = Charset.Charset('utf-8')
u1.body_encoding = None
u2 = Charset.Charset('utf-8')

u2.body_encoding != u1.body_encoding

[Florian Apolloner]

See ​https://github.com/django/django/blob/280c1a65ccacd679bf298bf2b169ff01e7266b8e/django/core/mail/message.py#L26 -- we purposely don't want to change anything globally. also are you talking about the 3.3.3 fix, or the 3.3.3+ fix and how exactly would your patch look like (and why would it be better than what we have now and would the tests pass ;))?