Changes between Initial Version and Version 1 of Ticket #19884, comment 3


Ignore:
Timestamp:
Jan 29, 2014, 12:10:27 PM (10 years ago)
Author:
Shai Berger

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #19884, comment 3

    initial v1  
    11I just posted [https://github.com/django/django/pull/2225/files PR 2225] which breaks `inspectdb.test_field_types()` in two: a `test_number_field_types()` which passes (the PR includes a fix to the !FloatField issue), and `test_field_types()` which does all the rest and is still marked expectedFailure; most of the fields tested there are !CharFields under Oracle, so fixing makes little sense indeed.
     2
     3I would have committed this immediately, except that the breaking of the test method includes some not-entirely-trivial factoring-out of code, and I'd like a second eye on that.
Back to Top