SelectDateWidget does not work correctly with has_changed()

[rene@…]

See http://groups.google.com/group/django-users/browse_thread/thread/45c2a4b6a2f0ba67

[René Fleschenberg]

Patch against the 1.3.X branch.

[René Fleschenberg]

The problem is that Widget._has_changed compares a localized string representation of the date to a datetime.date object. The patch addresses the issue by overriding _has_changed in SelectDateWidget and passing the data value as a datetime.date object to Widget._has_changed.

[René Fleschenberg]

Patch against trunk

[Julien Phalip]

Thanks for the report. The patch looks good, I'm just about to push it. You'll note that I've just fleshed out the tests a bit to be sure it works if the field's show_hidden_initial is True. Cheers!

[Julien Phalip]

In [17071]:

Fixed #17165 -- Fixed SelectDateWidget._has_changed() to work correctly with a localized date format.

[Julien Phalip]

rene_f, my apologies for not mentioning you in the commit message. Thanks again for your contribution.

[René Fleschenberg]

julien, no problem. Thanks for your quick reaction.

Will the fix also be applied to the 1.3.X branch? It might be nice to have it included in a possible 1.3.2 release. I attached a separate diff for 1.3.X (avoids datetime.strptime for Python 2.4 compatibility).

[Julien Phalip]

The policy is to only commit severe bug fixes to older branches; see: ​https://docs.djangoproject.com/en/dev/internals/release-process/#supported-versions
I don't think the severity of this bug qualifies, so you'll have to wait till the next release which should hopefully happen soon.

[fon.vosi@…]

doesn't work for me
when SelectDateWidget is empty and i check "if 'fieldname' in self.changed_data" for some other field
django fires TypeError "must be string, not None" in django/forms/extras/widgets.py "data = datetime_safe.datetime.strptime(data, input_format).date()"

so, you should make something like

if data is not None:

data = datetime_safe.datetime.strptime(data, input_format).date()

else:

data = None

[Volodymyr Tartynskyi]

it would be better

try:
  input_format = get_format('DATE_INPUT_FORMATS')[0]
  data = datetime.datetime.strptime(data, input_format).date()
except (TypeError, ValueError):
  pass

[anonymous]

This is a duplicate of: #17542 that is already fixed