Opened 13 years ago
Closed 13 years ago
#16186 closed Cleanup/optimization (fixed)
Remove inline CSS from admin templates
| Reported by: | bsimons | Owned by: | Chi Shang Cheng |
|---|---|---|---|
| Component: | contrib.admin | Version: | dev |
| Severity: | Normal | Keywords: | admin, templates, html, css, javascript |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | yes |
Description
The templates in contrib.admin have a lot of inline javascript. Also inline css styling appears at several places. This should be cleaned up so improving or redesigning the admin in the future is more easy. Javascripts could and should also be more based on jQuery, since it has been available in the admin anyway for some time now.
Attachments (2)
Change History (11)
follow-up: 4 comment:1 by , 13 years ago
| Has patch: | set |
|---|---|
| Owner: | changed from to |
by , 13 years ago
| Attachment: | 16186-inline-css-removed.diff added |
|---|
comment:2 by , 13 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|---|
| UI/UX: | set |
comment:3 by , 13 years ago
Aren't these two different issues? Cleaning up the admin pages to remove the inline javascript/css. Then as a seperate ticket, you could start converting the javascript to jQuery in a central place, if we even want to do that. Also, like Idan said, we should first create a shitlist of all inline css/js in the admin, maybe on a wiki.
comment:4 by , 13 years ago
| Patch needs improvement: | set |
|---|
Replying to cscheng:
Patch looks ok, but we might need more to close this ticket ;)
comment:5 by , 13 years ago
| Triage Stage: | Accepted → Design decision needed |
|---|
Yeah, on further reflection, this ticket aims to tackle way too much. There are already a number of tickets suggesting to convert some existing pieces of javascript to using jQuery: #13, #25, #15220, #13883, #15498, #15231, #13068. So the jQuery conversion should definitely stay out of this ticket and either be tackled piecemeal by these various tickets or be done all in one go as part of a major revamp of the admin.
Removing the inline CSS seems more reasonable for this ticket. However, a thorough audit of the existing codebase should be done first before deciding on the right approach for tackling this task.
For these reasons, I'm marking this ticket as DDN. I'm going to ask Idan for his view on this, as I assume he's got plans :)
comment:6 by , 13 years ago
| Summary: | The admin templates need some love → Remove inline CSS from admin templates |
|---|---|
| Triage Stage: | Design decision needed → Accepted |
OK, let's limit the scope of this ticket to removing inline CSS in the admin.
Eventually, we can open a separate ticket for inline JS/refactoring which doesn't fall under one of the existing tickets you mentioned already.
by , 13 years ago
| Attachment: | 16186-inline-css-removed-updated.diff added |
|---|
comment:8 by , 13 years ago
| Patch needs improvement: | unset |
|---|---|
| Triage Stage: | Accepted → Ready for checkin |
Patch for removing inline style in change_list_results.html (16186)