id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
12037	A ContextLazyObject-wrapped User breaks {% url myurlname user %}	Christian Hammond	Luke Plant	"r11623 breaks the {{{{% url %}}}} tag with 'user' (provided by the auth context processor) as an argument. Instead of 'user' being seen as a User object and transformed into a string, it's seen as a {{{ContextLazyObject}}}, which fails.

Now, maybe it's okay and that call sites should be expected to make sure they're passing the specific string instead of an object being represented as a string through {{{__unicode__}}}, but it does break some existing code. It should be explicit in the documentation if the decision is to not allow this anymore. I will point out though that it continues to work with other objects. I suspect what's really needed is that {{{ContextLazyObject}}} or {{{LazyObject}}} should be fixed so that it can be passed as a parameter in {{{{% url %}}}}.

The following template code (assuming a named url of ""userpage"") reproduces this for our app:

{{{
{% url userpage user %}
}}}

And this will show the following exception:

{{{
NoReverseMatch: Reverse for 'userpage' with arguments '(<django.core.context_processors.ContextLazyObject object at 0x124e190>,)' and keyword arguments '{}' not found.
Traceback (most recent call last):
  File ""/usr/local/lib/python2.6/dist-packages/django/core/handlers/base.py"", line 92, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File ""/home/chipx86/src/rb/reviewboard/reviewboard/accounts/decorators.py"", line 27, in _check
    return view_func(*args, **kwargs)
  File ""/home/chipx86/src/rb/reviewboard/reviewboard/reviews/views.py"", line 246, in review_detail
    'PRE_CREATION': PRE_CREATION,
  File ""/usr/local/lib/python2.6/dist-packages/django/shortcuts/__init__.py"", line 20, in render_to_response
    return HttpResponse(loader.render_to_string(*args, **kwargs), **httpresponse_kwargs)
  File ""/usr/local/lib/python2.6/dist-packages/django/template/loader.py"", line 108, in render_to_string
    return t.render(context_instance)
  File ""/usr/local/lib/python2.6/dist-packages/django/template/__init__.py"", line 178, in render
    return self.nodelist.render(context)
  File ""/usr/local/lib/python2.6/dist-packages/django/template/__init__.py"", line 779, in render
    bits.append(self.render_node(node, context))
  File ""/usr/local/lib/python2.6/dist-packages/django/template/debug.py"", line 71, in render_node
    result = node.render(context)
  File ""/usr/local/lib/python2.6/dist-packages/django/template/loader_tags.py"", line 97, in render
    return compiled_parent.render(context)
  File ""/usr/local/lib/python2.6/dist-packages/django/template/__init__.py"", line 178, in render
    return self.nodelist.render(context)
  File ""/usr/local/lib/python2.6/dist-packages/django/template/__init__.py"", line 779, in render
    bits.append(self.render_node(node, context))
  File ""/usr/local/lib/python2.6/dist-packages/django/template/debug.py"", line 71, in render_node
    result = node.render(context)
  File ""/usr/local/lib/python2.6/dist-packages/django/template/loader_tags.py"", line 97, in render
    return compiled_parent.render(context)
  File ""/usr/local/lib/python2.6/dist-packages/django/template/__init__.py"", line 178, in render
    return self.nodelist.render(context)
  File ""/usr/local/lib/python2.6/dist-packages/django/template/__init__.py"", line 779, in render
    bits.append(self.render_node(node, context))
  File ""/usr/local/lib/python2.6/dist-packages/django/template/debug.py"", line 71, in render_node
    result = node.render(context)
  File ""/usr/local/lib/python2.6/dist-packages/django/template/loader_tags.py"", line 24, in render
    result = self.nodelist.render(context)
  File ""/usr/local/lib/python2.6/dist-packages/django/template/__init__.py"", line 779, in render
    bits.append(self.render_node(node, context))
  File ""/usr/local/lib/python2.6/dist-packages/django/template/debug.py"", line 71, in render_node
    result = node.render(context)
  File ""/usr/local/lib/python2.6/dist-packages/django/template/loader_tags.py"", line 111, in render
    return self.template.render(context)
  File ""/usr/local/lib/python2.6/dist-packages/django/template/__init__.py"", line 178, in render
    return self.nodelist.render(context)
  File ""/usr/local/lib/python2.6/dist-packages/django/template/__init__.py"", line 779, in render
    bits.append(self.render_node(node, context))
  File ""/usr/local/lib/python2.6/dist-packages/django/template/debug.py"", line 81, in render_node
    raise wrapped
TemplateSyntaxError: Caught an exception while rendering: Reverse for 'userpage' with arguments '(<django.core.context_processors.ContextLazyObject object at 0x124e190>,)' and keyword arguments '{}' not found.
}}}"		closed	contrib.auth	1.1		fixed		chipx86@…	Unreviewed	0	0	0	0	0	0