id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
11548	choices in models.CharField accepts method but no property	gatwanagu	nobody	"Trying to generate the choices list for models.charField dynamically the following problem occurred.


{{{
somefield = = models.CharField(
    verbose_name=_('somefield'), 
    max_length=""20"", 
    choices=config.SOMEFIELD_CHOICES(),
    default=config.SOMEFIELD_DEFAULT,
    help_text=_('Some field.'),
    )
}}}
where SOMEFIELD_CHOICES was a method:
{{{
def SOMEFIELD_CHOICES():
    """"""Return subset of tuples as needed by Django""""""
    return [(key, u'%s' % value[0]) for (key, value) in _SOMEFIELD_CHOICES.iteritems()]
}}}

is accepted by the model check, while doing it like 
{{{
somefield = = models.CharField(
    verbose_name=_('somefield'), 
    max_length=""20"", 
    choices=config.SOMEFIELD_CHOICES,
    default=config.SOMEFIELD_DEFAULT,
    help_text=_('Some field.'),
    )
}}}
where SOMEFIELD_CHOICES is a property:
{{{
@property
def SOMEFIELD_CHOICES(:
    """"""Return subset of tuples as needed by Django""""""
    return [(key, u'%s' % value[0]) for (key, value) in _SOMEFIELD_CHOICES.iteritems()]
}}}
throws the following error:

{{{
Validating models...
Unhandled exception in thread started by <function inner_run at 0x01392B30>
Traceback (most recent call last):
  File ""D:\pyt\25\lib\site-packages\django\core\management\commands\runserver.py"", line 48, in inner_run
    self.validate(display_num_errors=True)
  File ""D:\pyt\25\lib\site-packages\django\core\management\base.py"", line 253, in validate
    raise CommandError(""One or more models did not validate:\n%s"" % error_text)
django.core.management.base.CommandError: One or more models did not validate:
example.example: ""somefield"": ""choices"" should be iterable (e.g., a tuple or list).
}}}

I feel that Django should also accept the property version.

Rgds
Günter"		closed	Uncategorized	dev		invalid			Unreviewed	0	0	0	0	0	0