id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
10711	Add a hook for specifying whether a form in a formset should be deleted	Brett Hoerner	jkocherhans	"save_existing_objects currently uses form._raw_value to check the DELETION_FIELD_NAME,

{{{
 if self.can_delete:
     raw_delete_value = form._raw_value(DELETION_FIELD_NAME)
     should_delete = form.fields[DELETION_FIELD_NAME].clean(raw_delete_value)
     if should_delete:
         self.deleted_objects.append(obj)
         obj.delete()
         continue
}}}

Is there any reason it can't use form.cleaned_data.get(DELETION_FIELD_NAME, False) instead?  By using _raw_value we prevent users from deciding to flag an inline for deletion during form validation.


{{{
 if self.can_delete:
     should_delete = form.cleaned_data.get(DELETION_FIELD_NAME, False)
     if should_delete:
         self.deleted_objects.append(obj)
         obj.delete()
         continue
}}}

Use case: Inline FormSet in the admin that detects certain inlines _should_ be deleted based on other information, and there is no need to bug to admin user for confirmation.

Definitely exists in 1.0.x and trunk."	New feature	closed	Forms		Normal	fixed	admin forms formset deletion		Accepted	1	0	0	0	0	0