id	summary	reporter	owner	description	type	status	component	version	severity	resolution	keywords	cc	stage	has_patch	needs_docs	needs_tests	needs_better_patch	easy	ui_ux
10235	contrib.sitemaps doesn't support RequestSite	Arthur Koziel	nobody	"The contrib.sitemaps app will always query the database for a Site object. It doesn't support RequestSite objects (http://docs.djangoproject.com/en/dev/ref/contrib/sites/#requestsite-objects).

The attached patch solves this issue. However, it is pretty hard to test this because the runtests.py has 'django.contrib.sites' in ALWAYS_INSTALLED_APPS, so checking if the app is installed with:

{{{
    if Site._meta.installed:
        current_site = Site.objects.get_current()
    else:
        current_site = RequestSite(request)
}}}

won't work because the tests will always assume that the app is installed and query the database.


"		closed	Contrib apps	1.0		fixed	sitemap	miracle2k	Accepted	1	0	0	0	0	0