Changeset 9440

Timestamp:

11/14/08 09:37:59 (8 months ago)

Author:

kmtracey

Message:

Fixed #9076 -- Changed BaseInlineFormSet? to not override BaseModelFormSet?'s get_queryset method. BaseInlineFormSet?'s method did not include a couple of fixes/enhancements that were made to the parent's method, resulting in excessive queries (some of which can return bad data due to #9006) for admin pages with inlines.

Files:

• django/trunk/django/forms/models.py (modified) (2 diffs)

django/trunk/django/forms/models.py

@@ -464 +464 @@
-        # is there a better way to get the object descriptor?
-        self.rel_name = RelatedObject(self.fk.rel.to, self.model, self.fk).get_accessor_name()
-
+
+
+
-
-    def _construct_forms(self):
@@ -480 +482 @@
-        return form
-    
-    def get_queryset(self):
-        """
-        Returns this FormSet's queryset, but restricted to children of
-        self.instance
-        """
-        kwargs = {self.fk.name: self.instance}
-        return self.model._default_manager.filter(**kwargs)
-
-    def save_new(self, form, commit=True):
-        kwargs = {self.fk.get_attname(): self.instance.pk}