Changeset 9053

Timestamp:

09/17/08 00:12:53 (4 months ago)

Author:

adrian

Message:

Fixed #8573 -- Fixed bug in 'inspectdb' regarding case-sensitivity of field names. It was automatically lowercasing the column name to create the Field name, which was inaccurate in the case of column names that contained a capital letter. Thanks for reporting and detective work, ramiro

Files:

• django/trunk/django/core/management/commands/inspectdb.py (modified) (4 diffs)

django/trunk/django/core/management/commands/inspectdb.py

@@ -42 +42 @@
-                indexes = {}
-            for i, row in enumerate(connection.introspection.get_table_description(cursor, table_name)):
-
+
+
-                comment_notes = [] # Holds Field notes, to be displayed in a Python comment.
-                extra_params = {}  # Holds Field parameters such as 'db_column'.
-
-we need to do field name modifiations, 
-remember the original field name
-
-att
-
-Now modify the field name to make it python compatible.  
+the column name can't be used verbatim as a Python
+attribute, set the "db_column" for this Field.
+ or column_name != att_name
+column
+
+Modify the field name to make it Python-compatible.
-                if ' ' in att_name:
-                    att_name = att_name.replace(' ', '_')
@@ -61 +62 @@
-                    att_name += '_field'
-                    comment_notes.append('Field renamed because it was a Python reserved word.')
+                if column_name != att_name:
+                    comment_notes.append('Field name made lowercase.')
-
-                if i in relations:
@@ -68 +71 @@
-                        att_name = att_name[:-3]
-                    else:
-att
+column
-                else:
-                    try:
@@ -91 +94 @@
-
-                    # Add primary_key and unique, if necessary.
-                    column_name = extra_params.get('db_column', att_name)
-                    if column_name in indexes:
-                        if indexes[column_name]['primary_key']: