Changeset 8783

Timestamp:

08/31/08 21:43:55 (3 months ago)

Author:

mtredinnick

Message:

Fixed #7512 -- Fixed an oversight when I first fixed ordering on nullable
foreign keys (r7761). Thanks to George Vilches for the test case here.

Files:

• django/trunk/django/db/models/sql/query.py (modified) (1 diff)
• django/trunk/tests/regressiontests/null_fk_ordering (added)
• django/trunk/tests/regressiontests/null_fk_ordering/__init__.py (added)
• django/trunk/tests/regressiontests/null_fk_ordering/models.py (added)

django/trunk/django/db/models/sql/query.py

@@ -659 +659 @@
-
-        # Must use left outer joins for nullable fields.
+        must_promote = False
-        for join in joins:
-self.promote_alias(join
+must_promote = self.promote_alias(join, must_promote
-
-        # If we get to this point and the field is a relation to another model,