Changeset 8724

Timestamp:

08/29/08 17:29:38 (3 months ago)

Author:

mtredinnick

Message:

Fixed a typo from the refactoring in [8455]. With bonus test, too. Thanks, vung.

Files:

• django/trunk/django/db/models/query.py (modified) (1 diff)
• django/trunk/tests/regressiontests/queries/models.py (modified) (1 diff)

django/trunk/django/db/models/query.py

@@ -738 +738 @@
-        field = self.model._meta.get_field(self._field_name, many_to_many=False)
-        assert isinstance(field, DateField), "%r isn't a DateField." \
-_
+.
-        self.query.add_date_select(field, self._kind, self._order)
-        if field.null:

django/trunk/tests/regressiontests/queries/models.py

@@ -902 +902 @@
->>> _ = pickle.loads(pickle.dumps(qs))
-
+Bug #8683 -- raise proper error when a DateQuerySet gets passed a wrong type of field
+>>> Item.objects.dates('name', 'month')
+Traceback (most recent call last):
+...
+AssertionError: 'name' isn't a DateField.
+
-Bug #8597: regression tests for case-insensitive comparisons
->>> _ = Item.objects.create(name="a_b", created=datetime.datetime.now(), creator=a2, note=n1)