Changeset 8618

Timestamp:

08/27/08 03:05:59 (3 months ago)

Author:

mtredinnick

Message:

Fixed #7289 -- Made ModelForms? behave like Forms in the sense that Field
objects don't appear as attributes on the final form instance. They continue to
appear as elements of the form_instance.fields mapping.

If you were relying on ModelForms? having fields as attributes, then this will
be slightly backwards incompatible. However, normal template usage will see no
change at all.

Patch from Daniel Pope.

Files:

• django/trunk/django/forms/models.py (modified) (2 diffs)

django/trunk/django/forms/models.py

@@ -164 +164 @@
-            # We are defining ModelForm itself.
-            parents = None
+        declared_fields = get_declared_fields(bases, attrs, False)
-        new_class = super(ModelFormMetaclass, cls).__new__(cls, name, bases,
-                attrs)
@@ -171 +172 @@
-        if 'media' not in attrs:
-            new_class.media = media_property(new_class)
-        declared_fields = get_declared_fields(bases, attrs, False)
-        opts = new_class._meta = ModelFormOptions(getattr(new_class, 'Meta', None))
-        if opts.model: