Changeset 8515 for django/trunk/tests/regressiontests/fixtures_regress

Timestamp:

08/24/08 03:12:13 (3 months ago)

Author:

russellm

Message:

Fixed #8298: Added a to_python method for integer fields. This ensures that the data from deserialized instances is of correct type prior to saving. Thanks to Andrew Badr for the report.

Files:

• django/trunk/tests/regressiontests/fixtures_regress/fixtures/animal.xml (added)
• django/trunk/tests/regressiontests/fixtures_regress/fixtures/sequence.json (modified) (1 diff)
• django/trunk/tests/regressiontests/fixtures_regress/models.py (modified) (3 diffs)

django/trunk/tests/regressiontests/fixtures_regress/fixtures/sequence.json

@@ -5 +5 @@
-        "fields": {
-            "name": "Lion", 
-
+
+
-        }
-    }

django/trunk/tests/regressiontests/fixtures_regress/models.py

@@ -7 +7 @@
-    name = models.CharField(max_length=150)
-    latin_name = models.CharField(max_length=150)
-
+
+
-    def __unicode__(self):
-        return self.common_name
+
+def animal_pre_save_check(signal, sender, instance, **kwargs):
+    "A signal that is used to check the type of data loaded from fixtures"
+    print 'Count = %s (%s)' % (instance.count, type(instance.count))
-
-class Plant(models.Model):
@@ -65 +70 @@
-# will take a PK of 1 (on Postgres), and the save will fail.
-# This is a regression test for ticket #3790.
-
+, count=2
->>> animal.save()
-
@@ -135 +140 @@
-[1, 2, 3, 4, 5, 6, 7, 8]
-
+###############################################
+# Test for ticket #8298 - Field values should be coerced into the correct type
+# by the deserializer, not as part of the database write.
+
+>>> models.signals.pre_save.connect(animal_pre_save_check)
+>>> management.call_command('loaddata', 'animal.xml', verbosity=0)
+Count = 42 (<type 'int'>)
+
+>>> models.signals.pre_save.disconnect(animal_pre_save_check)
+
-"""}