Changeset 8212

Timestamp:

08/05/08 11:13:28 (5 months ago)

Author:

jacob

Message:

Fixed #7904: added support for a "use_for_related_fields" property on managers. If True, the manager will be used for related object lookups instead of the "bare" QuerySet? introduced bu [8107]. Patch from Justin Bronn.

Files:

• django/trunk/django/db/models/fields/related.py (modified) (1 diff)
• django/trunk/docs/model-api.txt (modified) (1 diff)
• django/trunk/tests/regressiontests/reverse_single_related/models.py (modified) (2 diffs)

django/trunk/django/db/models/fields/related.py

@@ -240 +240 @@
-            else:
-                params = {'%s__exact' % self.field.rel.field_name: val}
-
+
+
+
+
+
+
+
+
-            setattr(instance, cache_name, rel_obj)
-            return rel_obj

django/trunk/docs/model-api.txt

@@ -1508 +1508 @@
-an inability to retrieve objects you'd like to work with.
-
+Using managers for related object access
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+By default, Django uses a "bare" (i.e. default) manager when accessing related
+objects (i.e. ``choice.poll``). If this default isn't appropriate for your default manager, you can force Django to use a custom manager for related object attributes by giving it a ``use_for_related_fields`` property::
+
+    class MyManager(models.Manager)::
+        use_for_related_fields = True
+        
+        ...
+
-Model methods
-=============

django/trunk/tests/regressiontests/reverse_single_related/models.py

@@ -27 +27 @@
->>> private_item = Item.objects.create(source=private_source)
-
-
+# 
-
->>> Source.objects.all()
@@ -35 +35 @@
-<Source: Source object>
-
-
-
+# 
+# 
-
->>> private_item.source
-<Source: Source object>
-
+# If the manager is marked "use_for_related_fields", it'll get used instead
+# of the "bare" queryset. Usually you'd define this as a property on the class,
+# but this approximates that in a way that's easier in tests.
+
+>>> Source.objects.use_for_related_fields = True
+>>> private_item = Item.objects.get(pk=private_item.pk)
+>>> private_item.source
+Traceback (most recent call last):
+    ...
+DoesNotExist: Source matching query does not exist.
+
-"""}