Django

Code

Changeset 7887

Show
Ignore:
Timestamp:
07/11/08 08:04:17 (6 months ago)
Author:
russellm
Message:

Fixed #7715 -- Modified the admin_scripts tests to do an app level import, rather than a project level import. This removes the potential for conflict between the admin script tests and the settings for the test suite itself. Thanks to Malcolm Tredinnick for his help hunting this one down.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • django/trunk/tests/regressiontests/admin_scripts/tests.py

    r7877 r7887  
    3030                 
    3131        if apps is None: 
    32             apps = ['django.contrib.auth', 'django.contrib.contenttypes', 'regressiontests.admin_scripts'] 
     32            apps = ['django.contrib.auth', 'django.contrib.contenttypes', 'admin_scripts'] 
    3333 
    3434        if apps: 
     
    6767            del os.environ['DJANGO_SETTINGS_MODULE'] 
    6868         
    69         os.environ['PYTHONPATH'] = os.pathsep.join([project_dir,base_dir]) 
    70          
     69        os.environ['PYTHONPATH'] = os.pathsep.join([test_dir,base_dir]) 
     70 
    7171        # Move to the test directory and run 
    7272        os.chdir(test_dir) 
     
    130130    def test_builtin_with_bad_settings(self): 
    131131        "no settings: django-admin builtin commands fail if settings file (from argument) doesn't exist" 
    132         args = ['sqlall','--settings=regressiontests.bad_settings', 'admin_scripts'] 
    133         out, err = self.run_django_admin(args) 
    134         self.assertNoOutput(out) 
    135         self.assertOutput(err, "Could not import settings 'regressiontests.bad_settings'") 
     132        args = ['sqlall','--settings=bad_settings', 'admin_scripts'] 
     133        out, err = self.run_django_admin(args) 
     134        self.assertNoOutput(out) 
     135        self.assertOutput(err, "Could not import settings 'bad_settings'") 
    136136 
    137137    def test_builtin_with_bad_environment(self): 
    138138        "no settings: django-admin builtin commands fail if settings file (from environment) doesn't exist" 
    139139        args = ['sqlall','admin_scripts'] 
    140         out, err = self.run_django_admin(args,'regressiontests.bad_settings') 
    141         self.assertNoOutput(out) 
    142         self.assertOutput(err, "Could not import settings 'regressiontests.bad_settings'") 
     140        out, err = self.run_django_admin(args,'bad_settings') 
     141        self.assertNoOutput(out) 
     142        self.assertOutput(err, "Could not import settings 'bad_settings'") 
    143143 
    144144 
     
    162162    def test_builtin_with_settings(self): 
    163163        "default: django-admin builtin commands succeed if settings are provided as argument" 
    164         args = ['sqlall','--settings=regressiontests.settings', 'admin_scripts'] 
     164        args = ['sqlall','--settings=settings', 'admin_scripts'] 
    165165        out, err = self.run_django_admin(args) 
    166166        self.assertNoOutput(err) 
     
    170170        "default: django-admin builtin commands succeed if settings are provided in the environment" 
    171171        args = ['sqlall','admin_scripts'] 
    172         out, err = self.run_django_admin(args,'regressiontests.settings') 
     172        out, err = self.run_django_admin(args,'settings') 
    173173        self.assertNoOutput(err) 
    174174        self.assertOutput(out, 'CREATE TABLE') 
     
    176176    def test_builtin_with_bad_settings(self): 
    177177        "default: django-admin builtin commands fail if settings file (from argument) doesn't exist" 
    178         args = ['sqlall','--settings=regressiontests.bad_settings', 'admin_scripts'] 
    179         out, err = self.run_django_admin(args) 
    180         self.assertNoOutput(out) 
    181         self.assertOutput(err, "Could not import settings 'regressiontests.bad_settings'") 
     178        args = ['sqlall','--settings=bad_settings', 'admin_scripts'] 
     179        out, err = self.run_django_admin(args) 
     180        self.assertNoOutput(out) 
     181        self.assertOutput(err, "Could not import settings 'bad_settings'") 
    182182 
    183183    def test_builtin_with_bad_environment(self): 
    184184        "default: django-admin builtin commands fail if settings file (from environment) doesn't exist" 
    185185        args = ['sqlall','admin_scripts'] 
    186         out, err = self.run_django_admin(args,'regressiontests.bad_settings') 
    187         self.assertNoOutput(out) 
    188         self.assertOutput(err, "Could not import settings 'regressiontests.bad_settings'") 
     186        out, err = self.run_django_admin(args,'bad_settings') 
     187        self.assertNoOutput(out) 
     188        self.assertOutput(err, "Could not import settings 'bad_settings'") 
    189189 
    190190    def test_custom_command(self): 
     
    197197    def test_custom_command_with_settings(self): 
    198198        "default: django-admin can't execute user commands, even if settings are provided as argument" 
    199         args = ['noargs_command', '--settings=regressiontests.settings'] 
     199        args = ['noargs_command', '--settings=settings'] 
    200200        out, err = self.run_django_admin(args) 
    201201        self.assertNoOutput(out) 
     
    205205        "default: django-admin can't execute user commands, even if settings are provided in environment" 
    206206        args = ['noargs_command'] 
    207         out, err = self.run_django_admin(args,'regressiontests.settings') 
     207        out, err = self.run_django_admin(args,'settings') 
    208208        self.assertNoOutput(out) 
    209209        self.assertOutput(err, "Unknown command: 'noargs_command'") 
     
    228228    def test_builtin_with_settings(self): 
    229229        "minimal: django-admin builtin commands fail if settings are provided as argument" 
    230         args = ['sqlall','--settings=regressiontests.settings', 'admin_scripts'] 
     230        args = ['sqlall','--settings=settings', 'admin_scripts'] 
    231231        out, err = self.run_django_admin(args) 
    232232        self.assertNoOutput(out) 
     
    236236        "minimal: django-admin builtin commands fail if settings are provided in the environment" 
    237237        args = ['sqlall','admin_scripts'] 
    238         out, err = self.run_django_admin(args,'regressiontests.settings') 
     238        out, err = self.run_django_admin(args,'settings') 
    239239        self.assertNoOutput(out) 
    240240        self.assertOutput(err, 'App with label admin_scripts could not be found') 
     
    242242    def test_builtin_with_bad_settings(self): 
    243243        "minimal: django-admin builtin commands fail if settings file (from argument) doesn't exist" 
    244         args = ['sqlall','--settings=regressiontests.bad_settings', 'admin_scripts'] 
    245         out, err = self.run_django_admin(args) 
    246         self.assertNoOutput(out) 
    247         self.assertOutput(err, "Could not import settings 'regressiontests.bad_settings'") 
     244        args = ['sqlall','--settings=bad_settings', 'admin_scripts'] 
     245        out, err = self.run_django_admin(args) 
     246        self.assertNoOutput(out) 
     247        self.assertOutput(err, "Could not import settings 'bad_settings'") 
    248248 
    249249    def test_builtin_with_bad_environment(self): 
    250250        "minimal: django-admin builtin commands fail if settings file (from environment) doesn't exist" 
    251251        args = ['sqlall','admin_scripts'] 
    252         out, err = self.run_django_admin(args,'regressiontests.bad_settings') 
    253         self.assertNoOutput(out) 
    254         self.assertOutput(err, "Could not import settings 'regressiontests.bad_settings'") 
     252        out, err = self.run_django_admin(args,'bad_settings') 
     253        self.assertNoOutput(out) 
     254        self.assertOutput(err, "Could not import settings 'bad_settings'") 
    255255             
    256256    def test_custom_command(self): 
     
    263263    def test_custom_command_with_settings(self): 
    264264        "minimal: django-admin can't execute user commands, even if settings are provided as argument" 
    265         args = ['noargs_command', '--settings=regressiontests.settings'] 
     265        args = ['noargs_command', '--settings=settings'] 
    266266        out, err = self.run_django_admin(args) 
    267267        self.assertNoOutput(out) 
     
    271271        "minimal: django-admin can't execute user commands, even if settings are provided in environment" 
    272272        args = ['noargs_command'] 
    273         out, err = self.run_django_admin(args,'regressiontests.settings') 
     273        out, err = self.run_django_admin(args,'settings') 
    274274        self.assertNoOutput(out) 
    275275        self.assertOutput(err, "Unknown command: 'noargs_command'") 
     
    294294    def test_builtin_with_settings(self): 
    295295        "alternate: django-admin builtin commands succeed if settings are provided as argument" 
    296         args = ['sqlall','--settings=regressiontests.alternate_settings', 'admin_scripts'] 
     296        args = ['sqlall','--settings=alternate_settings', 'admin_scripts'] 
    297297        out, err = self.run_django_admin(args) 
    298298        self.assertNoOutput(err) 
     
    302302        "alternate: django-admin builtin commands succeed if settings are provided in the environment" 
    303303        args = ['sqlall','admin_scripts'] 
    304         out, err = self.run_django_admin(args,'regressiontests.alternate_settings') 
     304        out, err = self.run_django_admin(args,'alternate_settings') 
    305305        self.assertNoOutput(err) 
    306306        self.assertOutput(out, 'CREATE TABLE') 
     
    308308    def test_builtin_with_bad_settings(self): 
    309309        "alternate: django-admin builtin commands fail if settings file (from argument) doesn't exist" 
    310         args = ['sqlall','--settings=regressiontests.bad_settings', 'admin_scripts'] 
    311         out, err = self.run_django_admin(args) 
    312         self.assertNoOutput(out) 
    313         self.assertOutput(err, "Could not import settings 'regressiontests.bad_settings'") 
     310        args = ['sqlall','--settings=bad_settings', 'admin_scripts'] 
     311        out, err = self.run_django_admin(args) 
     312        self.assertNoOutput(out) 
     313        self.assertOutput(err, "Could not import settings 'bad_settings'") 
    314314 
    315315    def test_builtin_with_bad_environment(self): 
    316316        "alternate: django-admin builtin commands fail if settings file (from environment) doesn't exist" 
    317317        args = ['sqlall','admin_scripts'] 
    318         out, err = self.run_django_admin(args,'regressiontests.bad_settings') 
    319         self.assertNoOutput(out) 
    320         self.assertOutput(err, "Could not import settings 'regressiontests.bad_settings'") 
     318        out, err = self.run_django_admin(args,'bad_settings') 
     319        self.assertNoOutput(out) 
     320        self.assertOutput(err, "Could not import settings 'bad_settings'") 
    321321 
    322322    def test_custom_command(self): 
     
    329329    def test_custom_command_with_settings(self): 
    330330        "alternate: django-admin can't execute user commands, even if settings are provided as argument" 
    331         args = ['noargs_command', '--settings=regressiontests.alternate_settings'] 
     331        args = ['noargs_command', '--settings=alternate_settings'] 
    332332        out, err = self.run_django_admin(args) 
    333333        self.assertNoOutput(out) 
     
    337337        "alternate: django-admin can't execute user commands, even if settings are provided in environment" 
    338338        args = ['noargs_command'] 
    339         out, err = self.run_django_admin(args,'regressiontests.alternate_settings') 
     339        out, err = self.run_django_admin(args,'alternate_settings') 
    340340        self.assertNoOutput(out) 
    341341        self.assertOutput(err, "Unknown command: 'noargs_command'") 
     
    365365    def test_builtin_with_settings(self): 
    366366        "alternate: django-admin builtin commands succeed if settings are provided as argument" 
    367         args = ['sqlall','--settings=regressiontests.alternate_settings', 'admin_scripts'] 
     367        args = ['sqlall','--settings=alternate_settings', 'admin_scripts'] 
    368368        out, err = self.run_django_admin(args) 
    369369        self.assertNoOutput(err) 
     
    373373        "alternate: django-admin builtin commands succeed if settings are provided in the environment" 
    374374        args = ['sqlall','admin_scripts'] 
    375         out, err = self.run_django_admin(args,'regressiontests.alternate_settings') 
     375        out, err = self.run_django_admin(args,'alternate_settings') 
    376376        self.assertNoOutput(err) 
    377377        self.assertOutput(out, 'CREATE TABLE') 
     
    379379    def test_builtin_with_bad_settings(self): 
    380380        "alternate: django-admin builtin commands fail if settings file (from argument) doesn't exist" 
    381         args = ['sqlall','--settings=regressiontests.bad_settings', 'admin_scripts'] 
    382         out, err = self.run_django_admin(args) 
    383         self.assertOutput(err, "Could not import settings 'regressiontests.bad_settings'") 
     381        args = ['sqlall','--settings=bad_settings', 'admin_scripts'] 
     382        out, err = self.run_django_admin(args) 
     383        self.assertOutput(err, "Could not import settings 'bad_settings'") 
    384384 
    385385    def test_builtin_with_bad_environment(self): 
    386386        "alternate: django-admin builtin commands fail if settings file (from environment) doesn't exist" 
    387387        args = ['sqlall','admin_scripts'] 
    388         out, err = self.run_django_admin(args,'regressiontests.bad_settings') 
    389         self.assertNoOutput(out) 
    390         self.assertOutput(err, "Could not import settings 'regressiontests.bad_settings'") 
     388        out, err = self.run_django_admin(args,'bad_settings') 
     389        self.assertNoOutput(out) 
     390        self.assertOutput(err, "Could not import settings 'bad_settings'") 
    391391 
    392392    def test_custom_command(self): 
     
    399399    def test_custom_command_with_settings(self): 
    400400        "alternate: django-admin can't execute user commands, even if settings are provided as argument" 
    401         args = ['noargs_command', '--settings=regressiontests.alternate_settings'] 
     401        args = ['noargs_command', '--settings=alternate_settings'] 
    402402        out, err = self.run_django_admin(args) 
    403403        self.assertNoOutput(out) 
     
    407407        "alternate: django-admin can't execute user commands, even if settings are provided in environment" 
    408408        args = ['noargs_command'] 
    409         out, err = self.run_django_admin(args,'regressiontests.alternate_settings') 
     409        out, err = self.run_django_admin(args,'alternate_settings') 
    410410        self.assertNoOutput(out) 
    411411        self.assertOutput(err, "Unknown command: 'noargs_command'")