Django

Code

Show
Ignore:
Timestamp:
07/06/08 20:45:19 (6 months ago)
Author:
mtredinnick
Message:

Fixed #4148 -- Changed the way attachments are served to IE to avoid some
caching and header-related bugs there. Only comes into play when Internet
Explorer is the user-agent.

Patch from Michael Axiak, with testing from Axis_of_Entropy and Karen Tracey.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • django/trunk/django/http/utils.py

    r7294 r7856  
    3232        response.content = '' 
    3333    return response 
     34 
     35def fix_IE_for_attach(request, response): 
     36    """ 
     37    This function will prevent Django from serving a Content-Disposition header 
     38    while expecting the browser to cache it (only when the browser is IE). This 
     39    leads to IE not allowing the client to download. 
     40    """ 
     41    if 'MSIE' not in request.META.get('HTTP_USER_AGENT', '').upper(): 
     42        return response 
     43 
     44    offending_headers = ('no-cache', 'no-store') 
     45    if response.has_header('Content-Disposition'): 
     46        try: 
     47            del response['Pragma'] 
     48        except KeyError: 
     49            pass 
     50        if response.has_header('Cache-Control'): 
     51            cache_control_values = [value.strip() for value in 
     52                    response['Cache-Control'].split(',') 
     53                    if value.strip().lower() not in offending_headers] 
     54 
     55            if not len(cache_control_values): 
     56                del response['Cache-Control'] 
     57            else: 
     58                response['Cache-Control'] = ', '.join(cache_control_values) 
     59 
     60    return response 
     61 
     62def fix_IE_for_vary(request, response): 
     63    """ 
     64    This function will fix the bug reported at 
     65    http://support.microsoft.com/kb/824847/en-us?spid=8722&sid=global 
     66    by clearing the Vary header whenever the mime-type is not safe 
     67    enough for Internet Explorer to handle.  Poor thing. 
     68    """ 
     69    if 'MSIE' not in request.META.get('HTTP_USER_AGENT', '').upper(): 
     70        return response 
     71 
     72    # These mime-types that are decreed "Vary-safe" for IE: 
     73    safe_mime_types = ('text/html', 'text/plain', 'text/sgml') 
     74 
     75    # The first part of the Content-Type field will be the MIME type, 
     76    # everything after ';', such as character-set, can be ignored. 
     77    if response['Content-Type'].split(';')[0] not in safe_mime_types: 
     78        try: 
     79            del response['Vary'] 
     80        except KeyError: 
     81            pass 
     82 
     83    return response 
     84