Changeset 7803

Timestamp:

06/30/08 07:18:29 (2 months ago)

Author:

russellm

Message:

Fixed #7572 -- Force the closure of the database connection at the end of fixture loading as a workaround for MySQL bug #37735. Thanks to Simon Litchfield for his help in narrowing down this issue.

Files:

• django/trunk/django/core/management/commands/loaddata.py (modified) (1 diff)
• django/trunk/tests/regressiontests/fixtures_regress/fixtures/big-fixture.json (added)
• django/trunk/tests/regressiontests/fixtures_regress/models.py (modified) (2 diffs)

django/trunk/django/core/management/commands/loaddata.py

@@ -163 +163 @@
-            if verbosity > 0:
-                print "Installed %d object(s) from %d fixture(s)" % (object_count, fixture_count)
+                
+        # Close the DB connection. This is required as a workaround for an
+        # edge case in MySQL: if the same connection is used to
+        # create tables, load data, and query, the query can return
+        # incorrect results. See Django #7572, MySQL #37735.
+        connection.close()

django/trunk/tests/regressiontests/fixtures_regress/models.py

@@ -45 +45 @@
-    data = models.CharField(max_length=10)
-
+# Models to regresison check #7572
+class Channel(models.Model):
+    name = models.CharField(max_length=255)
+
+class Article(models.Model):
+    title = models.CharField(max_length=255)
+    channels = models.ManyToManyField(Channel)
+    
+    class Meta:
+        ordering = ('id',)
-
-__test__ = {'API_TESTS':"""
@@ -108 +118 @@
->>> management.call_command('loaddata', 'model-inheritance.json', verbosity=0)
-
+###############################################
+# Test for ticket #7572 -- MySQL has a problem if the same connection is 
+# used to create tables, load data, and then query over that data.
+# To compensate, we close the connection after running loaddata.
+# This ensures that a new connection is opened when test queries are issued.
+
+>>> management.call_command('loaddata', 'big-fixture.json', verbosity=0)
+
+>>> articles = Article.objects.exclude(id=9)
+>>> articles.values_list('id', flat=True)
+[1, 2, 3, 4, 5, 6, 7, 8]
+
+# Just for good measure, run the same query again. Under the influence of
+# ticket #7572, this will give a different result to the previous call.
+>>> articles.values_list('id', flat=True)
+[1, 2, 3, 4, 5, 6, 7, 8]
+
-"""}