Changeset 7601

Timestamp:

06/09/08 11:17:54 (6 months ago)

Author:

jacob

Message:

Fixed #7298: prevent update() on sliced QuerySet? since UPDATE doesn't reliably support LIMIT/OFFSET. Thanks, George Vilches.

Files:

• django/trunk/django/db/models/query.py (modified) (2 diffs)
• django/trunk/tests/modeltests/update/models.py (modified) (1 diff)

django/trunk/django/db/models/query.py

@@ -293 +293 @@
-        fields to the appropriate values.
-        """
+        assert self.query.can_filter(), \
+                "Cannot update a query once a slice has been taken."
-        query = self.query.clone(sql.UpdateQuery)
-        query.add_update_values(kwargs)
@@ -307 +309 @@
-        useful at that level).
-        """
+        assert self.query.can_filter(), \
+                "Cannot update a query once a slice has been taken."
-        query = self.query.clone(sql.UpdateQuery)
-        query.add_update_fields(values)

django/trunk/tests/modeltests/update/models.py

@@ -64 +64 @@
-[{'value': u'thing'}]
-
+We do not support update on already sliced query sets.
+
+>>> DataPoint.objects.all()[:2].update(another_value='another thing')
+Traceback (most recent call last):
+    ...
+AssertionError: Cannot update a query once a slice has been taken.
+
-"""
-}