Changeset 7574 for django/trunk/tests/regressiontests/one_to_one_regress

Timestamp:

06/04/08 19:39:32 (3 months ago)

Author:

jacob

Message:

Fixed #6886: Tightened up ForeignKey? and OneToOne? field assignment. Specifically:

• Raise a ValueError? if you try to assign the wrong type of object.
  
• Raise a ValueError? if you try to assign None to a field not specified with null=True.
  
• Cache the set value at set time instead of just at lookup time.
  

This is a slightly backwards-incompatible change; see BackwardsIncompatibleChanges for more details.

Files:

• django/trunk/tests/regressiontests/one_to_one_regress/models.py (modified) (1 diff)

django/trunk/tests/regressiontests/one_to_one_regress/models.py

@@ -51 +51 @@
->>> p1.bar
-<Bar: Demon Dogs the bar>
+
+#
+# Regression test for #6886 (the related-object cache)
+# 
+
+# Look up the objects again so that we get "fresh" objects
+>>> p = Place.objects.get(name="Demon Dogs")
+>>> r = p.restaurant
+
+# Accessing the related object again returns the exactly same object
+>>> p.restaurant is r
+True
+
+# But if we kill the cache, we get a new object
+>>> del p._restaurant_cache
+>>> p.restaurant is r
+False
+
+# Reassigning the Restaurant object results in an immediate cache update
+# We can't use a new Restaurant because that'll violate one-to-one, but
+# with a new *instance* the is test below will fail if #6886 regresses.
+>>> r2 = Restaurant.objects.get(pk=r.pk)
+>>> p.restaurant = r2
+>>> p.restaurant is r2
+True
+
+# Assigning None fails: Place.restaurant is null=False
+>>> p.restaurant = None
+Traceback (most recent call last):
+    ...
+ValueError: Cannot assign None: "Place.restaurant" does not allow null values.
+
+# You also can't assign an object of the wrong type here
+>>> p.restaurant = p
+Traceback (most recent call last):
+    ...
+ValueError: Cannot assign "<Place: Demon Dogs the place>": "Place.restaurant" must be a "Restaurant" instance.
+
-"""}