Django

Code

Changeset 7146

Show
Ignore:
Timestamp:
02/22/08 18:23:57 (8 months ago)
Author:
mtredinnick
Message:

queryset-refactor: Fixed the case of calling update() on a model manager.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • django/branches/queryset-refactor/django/db/models/manager.py

    r7126 r7146  
    103103 
    104104    def update(self, *args, **kwargs): 
    105         return self.get_query_set().updated(*args, **kwargs) 
     105        return self.get_query_set().update(*args, **kwargs) 
    106106 
    107107    def _insert(self, *args, **kwargs): 

  • django/branches/queryset-refactor/django/db/models/sql/query.py

    r7144 r7146  
    12411241        result.append(', '.join(values)) 
    12421242        where, params = self.where.as_sql() 
    1243         result.append('WHERE %s' % where) 
     1243        if where: 
     1244            result.append('WHERE %s' % where) 
    12441245        return ' '.join(result), tuple(update_params + params) 
    12451246 

  • django/branches/queryset-refactor/tests/modeltests/update/models.py

    r7043 r7146  
    5757(u'fruit', u'peaches') 
    5858 
     59In the rare case you want to update every instance of a model, update() is also 
     60a manager method. 
     61 
     62>>> DataPoint.objects.update(value='thing') 
     63>>> DataPoint.objects.values('value').distinct() 
     64[{'value': u'thing'}] 
     65 
    5966""" 
    6067}